components/cronet/android/api/src/org/chromium/net/HttpUrlConnectionUrlRequestFactory.java - Issue 1429863008: [Cronet] Remove JSON serialization of CronetEngine.Builder

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/api/src/org/chromium/net/HttpUrlConnectionUrlRequestFactory.java

Issue 1429863008: [Cronet] Remove JSON serialization of CronetEngine.Builder (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address Helen's comments Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/cronet/android/api/src/org/chromium/net/CronetEngine.java ('K') | « components/cronet/android/api/src/org/chromium/net/CronetEngine.java ('k') | components/cronet/android/chromium_url_request_context.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/api/src/org/chromium/net/HttpUrlConnectionUrlRequestFactory.java

diff --git a/components/cronet/android/api/src/org/chromium/net/HttpUrlConnectionUrlRequestFactory.java b/components/cronet/android/api/src/org/chromium/net/HttpUrlConnectionUrlRequestFactory.java

index 89e5c010e18a0651fe257704c7152ef21ad9f6da..da456949addae11a7454cb0adcbcbfd9e8daa247 100644

--- a/components/cronet/android/api/src/org/chromium/net/HttpUrlConnectionUrlRequestFactory.java

+++ b/components/cronet/android/api/src/org/chromium/net/HttpUrlConnectionUrlRequestFactory.java

@@ -5,6 +5,7 @@

package org.chromium.net;

import android.content.Context;

+import android.text.TextUtils;

import java.io.IOException;

import java.io.PrintWriter;

@@ -24,7 +25,7 @@ class HttpUrlConnectionUrlRequestFactory extends HttpUrlRequestFactory {

public HttpUrlConnectionUrlRequestFactory(Context context, CronetEngine.Builder config) {

mContext = context;

String userAgent = config.getUserAgent();

- if (userAgent.isEmpty()) {

+ if (TextUtils.isEmpty(userAgent)) {

// Cannot use config.getDefaultUserAgent() as config.mContext may be null.

userAgent = new CronetEngine.Builder(mContext).getDefaultUserAgent();

}