Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(694)

Unified Diff: components/cronet/android/test/cronet_url_request_context_config_test.cc

Issue 1429863008: [Cronet] Remove JSON serialization of CronetEngine.Builder (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: sync Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/test/cronet_url_request_context_config_test.cc
diff --git a/components/cronet/android/test/cronet_url_request_context_config_test.cc b/components/cronet/android/test/cronet_url_request_context_config_test.cc
new file mode 100644
index 0000000000000000000000000000000000000000..dc413eb94ddd2298e69039e290d2f6fe28897f12
--- /dev/null
+++ b/components/cronet/android/test/cronet_url_request_context_config_test.cc
@@ -0,0 +1,51 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "cronet_url_request_context_config_test.h"
+
+#include <jni.h>
+
+#include "base/android/jni_android.h"
xunjieli 2015/12/01 17:30:38 Need to include base/logging.h for CHECK_EQ
pauljensen 2015/12/02 03:50:02 Done.
+#include "base/android/jni_string.h"
+#include "base/android/scoped_java_ref.h"
+#include "components/cronet/url_request_context_config.h"
+#include "jni/CronetUrlRequestContextTest_jni.h"
+
+namespace cronet {
+
+// Verify that all the config set by
xunjieli 2015/12/01 17:30:38 nit: s/Verify/Verifies s/config/configurations
pauljensen 2015/12/02 03:50:02 Done.
+// CronetUrlRequestContextTest.testCronetEngineBuilderConfig
+// made it from the CronetEngine.Builder to the URLRequestContextConfig.
+static void VerifyUrlRequestContextConfig(
+ JNIEnv* env,
+ const JavaParamRef<jclass>& jcaller,
+ jlong jurl_request_context_config,
+ const JavaParamRef<jstring>& jstorage_path) {
+ URLRequestContextConfig* config =
+ reinterpret_cast<URLRequestContextConfig*>(jurl_request_context_config);
+ CHECK_EQ(config->enable_spdy, false);
+ CHECK_EQ(config->enable_quic, true);
+ CHECK_EQ(config->enable_sdch, true);
+ CHECK_EQ(config->quic_hints.size(), 1u);
+ CHECK_EQ((*config->quic_hints.begin())->host, "example.com");
+ CHECK_EQ((*config->quic_hints.begin())->port, 12);
+ CHECK_EQ((*config->quic_hints.begin())->alternate_port, 34);
+ CHECK_EQ(config->load_disable_cache, false);
+ CHECK_EQ(config->http_cache, URLRequestContextConfig::HttpCacheType::MEMORY);
+ CHECK_EQ(config->http_cache_max_size, 54321);
+ CHECK_EQ(config->data_reduction_proxy_key, "abcd");
+ CHECK_EQ(config->user_agent, "efgh");
+ CHECK_EQ(config->experimental_options, "ijkl");
+ CHECK_EQ(config->data_reduction_primary_proxy, "mnop");
+ CHECK_EQ(config->data_reduction_fallback_proxy, "qrst");
+ CHECK_EQ(config->data_reduction_secure_proxy_check_url, "uvwx");
+ CHECK_EQ(config->storage_path,
+ base::android::ConvertJavaStringToUTF8(env, jstorage_path));
+}
+
+bool RegisterCronetUrlRequestContextConfigTest(JNIEnv* env) {
+ return RegisterNativesImpl(env);
+}
+
+} // namespace cronet

Powered by Google App Engine
This is Rietveld 408576698