Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 1429863004: Actually fix analysis link hovering (Closed)

Created:
5 years, 1 month ago by nduca
Modified:
5 years, 1 month ago
Reviewers:
beaudoin
CC:
catapult-reviews_chromium.org, tracing-review_chromium.org
Base URL:
https://github.com/catapult-project/catapult.git@master
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Actually fix analysis link hovering This introduces multiple brightening and dimming levels to the color palette. The presence of an event in any of the brushing state then increments or decrements an events brightness level. Roughly, the more brushed you are, the greater your brushing level. When there is a restriction, e.g. due to related events or find matches, then we start the world at a dim state, whereas without a restriction, then we start the world at the default state. This allows an event to be selected, and hovered, at the same time, and get the right brightening applied. Or, for it to be a non-selected find match, and get brightened. Note: The previous commit fa87f4592fc89633e66f5e8d899a1411de2ac16b was incorrectly titled as fixing analysis link hovering. That patch was just cleanup in preparation for this patch, but the CL description was stale at committing time. Whoops. TBR=beaudoin BUG=#1117 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/e09ee4ba6d1e146c457ecd7354f6494d1f8e42b0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+144 lines, -81 lines) Patch
M tracing/tracing/base/color.html View 3 chunks +12 lines, -3 lines 0 comments Download
M tracing/tracing/base/color_scheme.html View 3 chunks +52 lines, -33 lines 0 comments Download
M tracing/tracing/base/color_scheme_test.html View 1 chunk +0 lines, -13 lines 0 comments Download
M tracing/tracing/model/selection_state.html View 1 chunk +33 lines, -3 lines 0 comments Download
M tracing/tracing/ui/base/chart_base.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/base/event_presenter.html View 2 chunks +2 lines, -2 lines 0 comments Download
M tracing/tracing/ui/brushing_state.html View 2 chunks +38 lines, -20 lines 0 comments Download
M tracing/tracing/ui/brushing_state_test.html View 2 chunks +5 lines, -5 lines 0 comments Download
M tracing/tracing/ui/extras/chrome/cc/layer_tree_quad_stack_view.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1429863004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1429863004/1
5 years, 1 month ago (2015-10-31 20:10:16 UTC) #2
commit-bot: I haz the power
5 years, 1 month ago (2015-10-31 20:17:26 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698