Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 1429863002: Enable building Skia for iOS with bazel. (Closed)

Created:
5 years, 1 month ago by iroth
Modified:
5 years, 1 month ago
Reviewers:
dogben, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Enable building Skia for iOS with bazel. BUG=skia: Committed: https://skia.googlesource.com/skia/+/8b99ef434736791eefb31ecaa590a649dff83aed

Patch Set 1 #

Patch Set 2 : revert to single INCLUDE, removed Xcode 5 COPTS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -5 lines) Patch
M BUILD.public View 1 8 chunks +63 lines, -3 lines 0 comments Download
M tools/flags/SkCommandLineFlags.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
iroth
5 years, 1 month ago (2015-10-30 21:41:50 UTC) #2
mtklein
Ben, remind me how we best do this? Land the skia/ change first? Land the ...
5 years, 1 month ago (2015-11-02 13:56:03 UTC) #3
dogben
On 2015/11/02 at 13:56:03, mtklein wrote: > Ben, remind me how we best do this? ...
5 years, 1 month ago (2015-11-02 14:07:35 UTC) #4
dogben
On 2015/11/02 at 14:07:35, Ben Wagner wrote: > On 2015/11/02 at 13:56:03, mtklein wrote: > ...
5 years, 1 month ago (2015-11-02 14:10:22 UTC) #5
mtklein
lgtm
5 years, 1 month ago (2015-11-02 18:28:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1429863002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1429863002/20001
5 years, 1 month ago (2015-11-02 19:00:43 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/8b99ef434736791eefb31ecaa590a649dff83aed
5 years, 1 month ago (2015-11-02 19:11:24 UTC) #9
dogben
5 years, 1 month ago (2015-11-02 20:21:23 UTC) #10
Message was sent while issue was closed.
On 2015/11/02 at 19:11:24, commit-bot wrote:
> Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/8b99ef434736791eefb31ecaa590a649dff83aed

Rolled to google3 at cl/106862369.

Powered by Google App Engine
This is Rietveld 408576698