Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 1429833002: Cast Media Router: fix a few issues to pass some tests. (Closed)

Created:
5 years, 1 month ago by whywhat
Modified:
5 years, 1 month ago
Reviewers:
CC:
chromium-reviews, feature-media-reviews_chromium.org, mcasas+watch_chromium.org, media-router+watch_chromium.org, posciak+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cast Media Router: fix a few issues to pass some tests. Landing this for Mounir due to the merge conflicts. * Properly set requestId to be used to track sequenceNumber. * Properly re-route names that are different outside and inside MEDIA namespace. BUG=549134, 548822 TBR=mlamouri@chromium.org patch from issue 1420973009 at patchset 20001 (http://crrev.com/1420973009#ps20001) Committed: https://crrev.com/be58ed1de6b773dbe9a0c3678d9546ac955e8ce1 Cr-Commit-Position: refs/heads/master@{#357180}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+136 lines, -63 lines) Patch
A chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastRequestIdGenerator.java View 1 chunk +37 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastRouteController.java View 16 chunks +99 lines, -63 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1429833002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1429833002/1
5 years, 1 month ago (2015-10-30 19:20:22 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-30 20:12:54 UTC) #4
commit-bot: I haz the power
5 years, 1 month ago (2015-10-30 20:13:55 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/be58ed1de6b773dbe9a0c3678d9546ac955e8ce1
Cr-Commit-Position: refs/heads/master@{#357180}

Powered by Google App Engine
This is Rietveld 408576698