This CL implements the first draft of Canvas 2D Context Attributes, aka getContext('2d', { alpha: f…

Source/core/html/canvas/Canvas2DContextAttributes.h

Index: Source/core/html/canvas/Canvas2DContextAttributes.h
diff --git a/Source/core/html/canvas/CanvasContextAttributes.cpp b/Source/core/html/canvas/Canvas2DContextAttributes.h
similarity index 69%
copy from Source/core/html/canvas/CanvasContextAttributes.cpp
copy to Source/core/html/canvas/Canvas2DContextAttributes.h
index d3d0398afd60b5807f84fa9367a15de17ef3b7da..dbf15864a60d216576bf37656f0861f5596addee 100644
--- a/Source/core/html/canvas/CanvasContextAttributes.cpp
+++ b/Source/core/html/canvas/Canvas2DContextAttributes.h
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2010, Google Inc. All rights reserved.
+ * Copyright (c) 2013, Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
@@ -24,18 +24,31 @@
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
-#include "config.h"
+#ifndef Canvas2DContextAttributes_h
+#define Canvas2DContextAttributes_h
 
 #include "CanvasContextAttributes.h"
+#include <wtf/PassRefPtr.h>
 
 namespace WebCore {
 
-CanvasContextAttributes::CanvasContextAttributes()
-{
-}
+class Canvas2DContextAttributes : public CanvasContextAttributes {

[jamesr, 2013/04/26 00:41:31]

WebGLContextAttributes has an alpha bit. why can't you just promote that up to
the base class?

[Stephen White, 2013/04/26 15:51:03]

On the C++ side, WebGLContextAttributes stores all its data in a
GraphicsContext3D::Attributes internally, so I'd have to pull it out of there
and change the callers to reference the new flag as well as the ::Attributes. I
don't see a big benefit to that.

On the IDL side, there is no base class between the two currently, so I think
that would have to be changed for both WebGL and Canvas at the spec level
(they're just two dictionaries that quack alike).

+public:
+    virtual ~Canvas2DContextAttributes();
 
-CanvasContextAttributes::~CanvasContextAttributes()
-{
-}
+    // Create a new attributes object
+    static PassRefPtr<Canvas2DContextAttributes> create();
+
+    // Whether or not the drawing buffer has an alpha channel; default=true
+    bool alpha() const;
+    void setAlpha(bool);
+
+protected:
+    Canvas2DContextAttributes();
+
+    bool m_alpha;
+};
 
 } // namespace WebCore
+
+#endif // Canvas2DContextAttributes_h