Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Issue 14298015: Fix background color to ensure notification text color is preserved. (Closed)

Created:
7 years, 8 months ago by dharcourt
Modified:
7 years, 8 months ago
Reviewers:
Jun Mukai
CC:
chromium-reviews
Visibility:
Public.

Description

Fix background color to ensure notification text color is preserved. Since the text color changed, its backround color has to change also otherwise Label's GetReadableColor() will use a computed text color instead of the specified one. BUG=230068 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195403

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M ui/message_center/views/notification_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 20 (0 generated)
dharcourt
7 years, 8 months ago (2013-04-20 00:58:11 UTC) #1
dharcourt
Hi Jun, this is a little fix I'm trying to get into tonight's build. PTAL ...
7 years, 8 months ago (2013-04-20 01:06:13 UTC) #2
Jun Mukai
lgtm
7 years, 8 months ago (2013-04-20 01:12:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dharcourt@chromium.org/14298015/1
7 years, 8 months ago (2013-04-20 01:24:38 UTC) #4
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 8 months ago (2013-04-20 03:02:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dharcourt@chromium.org/14298015/1
7 years, 8 months ago (2013-04-20 03:26:23 UTC) #6
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 8 months ago (2013-04-20 03:33:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dharcourt@chromium.org/14298015/1
7 years, 8 months ago (2013-04-20 04:45:38 UTC) #8
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 8 months ago (2013-04-20 04:54:51 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dharcourt@chromium.org/14298015/4
7 years, 8 months ago (2013-04-20 05:58:41 UTC) #10
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 8 months ago (2013-04-20 05:59:31 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dharcourt@chromium.org/14298015/4
7 years, 8 months ago (2013-04-20 06:19:26 UTC) #12
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 8 months ago (2013-04-20 06:26:10 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dharcourt@chromium.org/14298015/4
7 years, 8 months ago (2013-04-20 13:59:49 UTC) #14
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 8 months ago (2013-04-20 14:06:30 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dharcourt@chromium.org/14298015/4
7 years, 8 months ago (2013-04-20 17:17:26 UTC) #16
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 8 months ago (2013-04-20 17:24:26 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dharcourt@chromium.org/14298015/4
7 years, 8 months ago (2013-04-20 22:10:38 UTC) #18
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 8 months ago (2013-04-20 22:17:49 UTC) #19
dharcourt
7 years, 8 months ago (2013-04-20 22:55:19 UTC) #20
Message was sent while issue was closed.
Committed patchset #1 manually as r195403 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698