Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 14298014: Revert 194441 "Better support for chrome for cros local builds." (Closed)

Created:
7 years, 8 months ago by Julien - ping for review
Modified:
7 years, 8 months ago
Reviewers:
achuithb
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 194441 "Better support for chrome for cros local builds." The Perf Blink bots are failing with the following error: File "/b/build/slave/Linux_Perf/build/src/tools/telemetry/telemetry/core/chrome/desktop_browser_finder.py", line 129, in AddCrOSIfFound ldd_out = subprocess.check_output([ldd_path, app]) AttributeError: 'module' object has no attribute 'check_output' > Better support for chrome for cros local builds. > > * Use ldd to detect chrome for cros local builds. > * Add browser types debug-cros and release-cros for chrome for cros on linux. > * Remove browser option --cros-desktop > > BUG=229692 > TEST=run_tests works with cros-debug going through the login flow. > NOTRY=True > Review URL: https://codereview.chromium.org/14102002 TBR=achuith@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194466

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -30 lines) Patch
M trunk/src/tools/telemetry/telemetry/core/browser_options.py View 2 chunks +6 lines, -0 lines 0 comments Download
M trunk/src/tools/telemetry/telemetry/core/chrome/desktop_browser_backend.py View 4 chunks +3 lines, -5 lines 0 comments Download
M trunk/src/tools/telemetry/telemetry/core/chrome/desktop_browser_finder.py View 2 chunks +2 lines, -25 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Julien - ping for review
7 years, 8 months ago (2013-04-16 22:19:20 UTC) #1
Julien - ping for review
Committed patchset #1 manually as r194466.
7 years, 8 months ago (2013-04-16 22:19:31 UTC) #2
achuithb
7 years, 8 months ago (2013-04-17 19:09:02 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698