Issue 14298013: Check focusability in WindowFocusedFromInputEvent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14298013: Check focusability in WindowFocusedFromInputEvent (Closed)

Created:
7 years, 8 months ago by stevenjb

Modified:
7 years, 8 months ago

Reviewers:
flackr, Ben Goodger (Google)

CC:
chromium-reviews, tfarina, sadrul, ben+watch_chromium.org, sschmitz

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Check focusability in WindowFocusedFromInputEvent Only change focus in FocusController::WindowFocusedFromInputEvent if window hierarchy is focusable. BUG=225851 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194955

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+58 lines, -5 lines)			Patch
M	ash/wm/window_manager_unittest.cc	View		1 chunk	+38 lines, -0 lines	0 comments	Download
M	ui/views/corewm/focus_controller.cc	View	1	1 chunk	+5 lines, -1 line	0 comments	Download
M	ui/views/corewm/focus_controller_unittest.cc	View	1 2	6 chunks	+15 lines, -4 lines	0 comments	Download

Total messages: 5 (0 generated)

stevenjb

This fixes the underlying window focus problem causing crbug.com/225851. I also added a test that ...

7 years, 8 months ago (2013-04-16 22:22:53 UTC) #1

stevenjb

PTAL. Had to update FocusController views_unittests for new behavior.

7 years, 8 months ago (2013-04-17 20:38:22 UTC) #3

stevenjb

7 years, 8 months ago (2013-04-18 17:11:55 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 manually as r194955 (presubmit successful).