Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 14298010: Updates to images project. (Closed)

Created:
7 years, 8 months ago by scroggo
Modified:
7 years, 8 months ago
Reviewers:
djsollen
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Updates to images project. Use the SkImageEncoder_Factory on all platforms. On Windows and Mac, register the platform's image encoder as an option for SkImageEncoder::Create. Also add more types that can be decoded. Update comments for SkImageDecoder to be more accurate. Add more types to SkImageEncoder::Type, and return the correct type of encoder, if it exists. Use a custom version of SkImageDecoder::Factory on Windows and Mac to check the stream for registered decoders before defaulting to the platform's version. Share code with the existing SkImageDecoder::Factory method. Preparation for testing decoders and encoders: BUG=https://code.google.com/p/skia/issues/detail?id=1241 Committed: https://code.google.com/p/skia/source/detail?r=8730

Patch Set 1 : #

Patch Set 2 : Fix up comments. #

Patch Set 3 : Name changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -105 lines) Patch
M gyp/images.gyp View 1 2 4 chunks +5 lines, -6 lines 0 comments Download
M include/images/SkImageDecoder.h View 1 2 chunks +4 lines, -3 lines 0 comments Download
M include/images/SkImageEncoder.h View 1 chunk +5 lines, -1 line 0 comments Download
M src/images/SkImageDecoder_Factory.cpp View 1 2 1 chunk +0 lines, -63 lines 0 comments Download
A src/images/SkImageDecoder_FactoryDefault.cpp View 1 2 1 chunk +37 lines, -0 lines 0 comments Download
A + src/images/SkImageDecoder_FactoryRegistrar.cpp View 1 2 2 chunks +8 lines, -24 lines 0 comments Download
M src/ports/SkImageDecoder_CG.cpp View 3 chunks +30 lines, -4 lines 0 comments Download
M src/ports/SkImageDecoder_WIC.cpp View 3 chunks +30 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scroggo
7 years, 8 months ago (2013-04-17 20:24:00 UTC) #1
djsollen
lgtm and feel free to make the name changes.
7 years, 8 months ago (2013-04-17 20:48:41 UTC) #2
scroggo
7 years, 8 months ago (2013-04-17 21:08:03 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r8730 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698