Select packages that match SDK constraints.

utils/tests/pub/version_solver_test.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library pub_update_test;
 
 import 'dart:async';
 import 'dart:io';
 
 import 'package:unittest/unittest.dart';
 
 import '../../pub/lock_file.dart';
 import '../../pub/package.dart';
 import '../../pub/pubspec.dart';
+import '../../pub/sdk.dart' as sdk;
 import '../../pub/source.dart';
 import '../../pub/source_registry.dart';
 import '../../pub/system_cache.dart';
 import '../../pub/utils.dart';
 import '../../pub/version.dart';
 import '../../pub/solver/version_solver.dart';
 import 'test_pub.dart';
 
 MockSource source1;
 MockSource source2;
 
 bool allowBacktracking;
 
 main() {
   initConfig();
 
+  // Since this test isn't run from the SDK, it can't find the "version" file
+  // to load. Instead, just manually inject a version.
+  sdk.version = new Version(1, 2, 3);
+
   for (allowBacktracking in [false, true]) {
     group(allowBacktracking ? 'BackTrackingSolver' : 'GreedySolver', () {
       group('basic graph', basicGraph);
       group('with lockfile', withLockFile);
       group('root dependency', rootDependency);
       group('dev dependency', devDependency);
       group('unsolvable', unsolvable);
       group('backtracking', backtracking);
     });
   }
+
+  // These tests are only valid with the backtracking solver.
+  allowBacktracking = true;
+  group('SDK constraint', sdkConstraint);
 }
 
 void basicGraph() {
   testResolve('no dependencies', {
     'myapp 0.0.0': {}
   }, result: {
     'myapp from root': '0.0.0'
   });
 
   testResolve('simple dependency tree', {
@@ skipping 488 matching lines @@
     'baz': '0.0.0'
   }, maxTries: 100);
 
   // TODO(rnystrom): More tests. In particular:
   // - Tests that demonstrate backtracking for every case that can cause a
   //   solution to fail (no versions, disjoint, etc.)
   // - Tests where there are multiple valid solutions and "best" is possibly
   //   ambiguous to nail down which order the backtracker tries solutions.
 }
 
+sdkConstraint() {
+  var badVersion = '0.0.0-nope';
+  var goodVersion = sdk.version.toString();
+
+  testResolve('root matches SDK', {
+    'myapp 0.0.0': {'sdk': goodVersion }
+  }, result: {
+    'myapp from root': '0.0.0'
+  });
+
+  testResolve('root does not match SDK', {
+    'myapp 0.0.0': {'sdk': badVersion }
+  }, error: couldNotSolve);
+
+  testResolve('dependency does not match SDK', {
+    'myapp 0.0.0': {'foo': 'any'},
+    'foo 0.0.0': {'sdk': badVersion }
+  }, error: couldNotSolve);
+
+  testResolve('transitive dependency does not match SDK', {
+    'myapp 0.0.0': {'foo': 'any'},
+    'foo 0.0.0': {'bar': 'any'},
+    'bar 0.0.0': {'sdk': badVersion }
+  }, error: couldNotSolve);
+
+  testResolve('selects a dependency version that allows the SDK', {
+    'myapp 0.0.0': {'foo': 'any'},
+    'foo 1.0.0': {'sdk': goodVersion },
+    'foo 2.0.0': {'sdk': goodVersion },
+    'foo 3.0.0': {'sdk': badVersion },
+    'foo 4.0.0': {'sdk': badVersion }
+  }, result: {
+    'myapp from root': '0.0.0',
+    'foo': '2.0.0'
+  }, maxTries: 3);
+
+  testResolve('selects a transitive dependency version that allows the SDK', {
+    'myapp 0.0.0': {'foo': 'any'},
+    'foo 1.0.0': {'bar': 'any'},
+    'bar 1.0.0': {'sdk': goodVersion },
+    'bar 2.0.0': {'sdk': goodVersion },
+    'bar 3.0.0': {'sdk': badVersion },
+    'bar 4.0.0': {'sdk': badVersion }
+  }, result: {
+    'myapp from root': '0.0.0',
+    'foo': '1.0.0',
+    'bar': '2.0.0'
+  }, maxTries: 3);
+
+  testResolve('selects a dependency version that allows a transitive '
+              'dependency that allows the SDK', {
+    'myapp 0.0.0': {'foo': 'any'},
+    'foo 1.0.0': {'bar': '1.0.0'},
+    'foo 2.0.0': {'bar': '2.0.0'},
+    'foo 3.0.0': {'bar': '3.0.0'},
+    'foo 4.0.0': {'bar': '4.0.0'},
+    'bar 1.0.0': {'sdk': goodVersion },
+    'bar 2.0.0': {'sdk': goodVersion },
+    'bar 3.0.0': {'sdk': badVersion },
+    'bar 4.0.0': {'sdk': badVersion }
+  }, result: {
+    'myapp from root': '0.0.0',
+    'foo': '2.0.0',
+    'bar': '2.0.0'
+  }, maxTries: 3);
+}
+
 testResolve(description, packages,
             {lockfile, result, FailMatcherBuilder error, int maxTries,
              bool hasGreedySolution}) {
   // Close over the top-level variable since it will be mutated.
   var allowBacktracking_ = allowBacktracking;
 
   if (maxTries == null) maxTries = 1;
   if (hasGreedySolution == null) hasGreedySolution = maxTries == 1;
 
   if (!allowBacktracking_) {
@@ skipping 292 matching lines @@
   }
 
   void addPackage(String description, Package package) {
     _packages.putIfAbsent(description, () => new Map<Version, Package>());
     _packages[description][package.version] = package;
   }
 }
 
 Package mockPackage(String description, String version,
                     Map dependencyStrings) {
+  var sdkConstraint = null;
+
   // Build the pubspec dependencies.
   var dependencies = <PackageRef>[];
   var devDependencies = <PackageRef>[];
 
   dependencyStrings.forEach((name, constraint) {
     parseSource(name, (isDev, name, source) {
       var packageName = name.replaceFirst(new RegExp(r"-[^-]+$"), "");
-      var ref = new PackageRef(packageName, source,
-          new VersionConstraint.parse(constraint), name);
+      constraint = new VersionConstraint.parse(constraint);
+
+      if (name == 'sdk') {
+        sdkConstraint = constraint;
+        return;
+      }
+
+      var ref = new PackageRef(packageName, source, constraint, name);
 
       if (isDev) {
         devDependencies.add(ref);
       } else {
         dependencies.add(ref);
       }
     });
   });
 
   var name = description.replaceFirst(new RegExp(r"-[^-]+$"), "");
   var pubspec = new Pubspec(
       name, new Version.parse(version), dependencies, devDependencies,
-      new PubspecEnvironment());
+      new PubspecEnvironment(sdkConstraint));
   return new Package.inMemory(pubspec);
 }
 
 void parseSource(String description,
     callback(bool isDev, String name, Source source)) {
   var isDev = false;
 
   if (description.startsWith("(dev) ")) {
     description = description.substring("(dev) ".length);
     isDev = true;
   }
 
   var name = description;
   var source = source1;
 
   var sourceNames = {
     'mock1': source1,
     'mock2': source2,
     'root': null
   };
 
   var match = new RegExp(r"(.*) from (.*)").firstMatch(description);
   if (match != null) {
     name = match[1];
     source = sourceNames[match[2]];
   }
 
   callback(isDev, name, source);
 }