Unify calling to GenerateFastApiCallBody before stubbing it

Unify calling to GenerateFastApiCallBody before stubbing it

R=verwaest@chromium.org

BUG=

Committed: https://code.google.com/p/v8/source/detail?r=18714

[Toon Verwaest, 2014-01-20 19:11:09]

Nice cleanup! lgtm

https://codereview.chromium.org/142973005/diff/1/src/x64/stub-cache-x64.cc
File src/x64/stub-cache-x64.cc (right):

https://codereview.chromium.org/142973005/diff/1/src/x64/stub-cache-x64.cc#ne...
src/x64/stub-cache-x64.cc:417: Handle<Map>
Handle<Map> prototype_map(
    JSObject::cast(current_map->prototype())->map());

https://codereview.chromium.org/142973005/diff/1/src/x64/stub-cache-x64.cc#ne...
src/x64/stub-cache-x64.cc:426: CHECK(false);
UNREACHABLE();

https://codereview.chromium.org/142973005/diff/1/src/x64/stub-cache-x64.cc#ne...
src/x64/stub-cache-x64.cc:703: api_receiver,
Handle<JSObject>(lookup->holder()));
This entire code part is a bit weird to me. Why would we have an interceptor
case if there's a holder above the interceptor? Or that just because the holder
is completely unrelated to the thing that holds the API function? Is that why
you called it api_holder?

[dcarney, 2014-01-20 20:23:55]

https://codereview.chromium.org/142973005/diff/1/src/x64/stub-cache-x64.cc
File src/x64/stub-cache-x64.cc (right):

https://codereview.chromium.org/142973005/diff/1/src/x64/stub-cache-x64.cc#ne...
src/x64/stub-cache-x64.cc:703: api_receiver,
Handle<JSObject>(lookup->holder()));
On 2014/01/20 19:11:09, Toon Verwaest wrote:
> This entire code part is a bit weird to me. Why would we have an interceptor
> case if there's a holder above the interceptor? Or that just because the
holder
> is completely unrelated to the thing that holds the API function? Is that why
> you called it api_holder?

exactly.  It's not what you'd expect to call a holder, but it's between the
receiver and the holder on the chain.  it would be nice to delete all this
garbage with recursive interceptors

[Toon Verwaest, 2014-01-21 11:30:59]

lgtm. Just remove the debug print.

https://codereview.chromium.org/142973005/diff/90002/src/x64/stub-cache-x64.cc
File src/x64/stub-cache-x64.cc (right):

https://codereview.chromium.org/142973005/diff/90002/src/x64/stub-cache-x64.c...
src/x64/stub-cache-x64.cc:427: fprintf(stderr, "%s %p %p\n", __func__,
*map_to_holder, *holder);
Remove debugging code.

[dcarney, 2014-01-21 15:07:03]

Committed patchset #4 manually as r18714 (presubmit successful).