Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 14297008: Benchmark to measure SkSurface copy on write performance (Closed)

Created:
7 years, 8 months ago by Justin Novosad
Modified:
7 years, 8 months ago
Reviewers:
reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Benchmark to measure SkSurface copy on write performance Committed: https://code.google.com/p/skia/source/detail?r=8718

Patch Set 1 #

Total comments: 6

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -0 lines) Patch
A bench/DeferredSurfaceCopyBench.cpp View 1 2 1 chunk +87 lines, -0 lines 0 comments Download
M gyp/bench.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Justin Novosad
PTAL
7 years, 8 months ago (2013-04-16 20:33:30 UTC) #1
reed1
https://codereview.chromium.org/14297008/diff/1/bench/DeferredSurfaceCopyBench.cpp File bench/DeferredSurfaceCopyBench.cpp (right): https://codereview.chromium.org/14297008/diff/1/bench/DeferredSurfaceCopyBench.cpp#newcode39 bench/DeferredSurfaceCopyBench.cpp:39: info.fWidth = referenceDevice->width(); Is it important to match this ...
7 years, 8 months ago (2013-04-16 20:37:24 UTC) #2
Justin Novosad
New Patch https://codereview.chromium.org/14297008/diff/1/bench/DeferredSurfaceCopyBench.cpp File bench/DeferredSurfaceCopyBench.cpp (right): https://codereview.chromium.org/14297008/diff/1/bench/DeferredSurfaceCopyBench.cpp#newcode39 bench/DeferredSurfaceCopyBench.cpp:39: info.fWidth = referenceDevice->width(); On 2013/04/16 20:37:24, reed1 ...
7 years, 8 months ago (2013-04-16 20:50:48 UTC) #3
reed1
7 years, 8 months ago (2013-04-16 21:09:45 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698