Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Issue 14297007: Make DOMWrapperWorlds easier to use (Closed)

Created:
7 years, 8 months ago by adamk
Modified:
7 years, 8 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, haraken, Nate Chapin, abarth-chromium
Visibility:
Public.

Description

Make DOMWrapperWorlds easier to use This patch adds a DOMWrapperWorld::current() static method that returns either the DOMWrapperWorld for the current V8 context or null if in a Worker. Recently-transitioned callsites that previously used WorkerContextHandle have been updated to call DOMWrapperWorld::current() instead, and it will be used in upcoming WorldContextHandle transitions. This lets us remove a FIXME in toV8Context() since all non-Worker callers now pass in a non-null DOMWrapperWorld (rather than the old behavior of passing null as a sentinel for "main world"). R=abarth BUG=230460 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=148501

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -9 lines) Patch
M Source/bindings/scripts/CodeGeneratorV8.pm View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/DOMWrapperWorld.h View 2 chunks +4 lines, -0 lines 0 comments Download
M Source/bindings/v8/DOMWrapperWorld.cpp View 2 chunks +11 lines, -0 lines 0 comments Download
M Source/bindings/v8/V8Binding.cpp View 1 chunk +3 lines, -7 lines 0 comments Download
M Source/bindings/v8/V8MutationCallback.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
adamk
7 years, 8 months ago (2013-04-16 20:30:54 UTC) #1
adamk
Note that we discussed offline whether workers should have their own DOMWrapperWorld, rather than using ...
7 years, 8 months ago (2013-04-16 20:33:01 UTC) #2
abarth-chromium
Looks great! LGTM
7 years, 8 months ago (2013-04-16 20:56:51 UTC) #3
adamk
7 years, 8 months ago (2013-04-16 22:07:28 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r148501 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698