Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1429693006: rename yuv matrix constants to be more clear about what they are (Closed)

Created:
5 years, 1 month ago by fbarchard1
Modified:
5 years, 1 month ago
Reviewers:
harryjin, fbarchard
Base URL:
https://chromium.googlesource.com/libyuv/libyuv@master
Target Ref:
refs/heads/master
Project:
libyuv
Visibility:
Public.

Description

rename yuv matrix constants to be more clear about what they are R=harryjin@google.com BUG=none Committed: https://chromium.googlesource.com/libyuv/libyuv/+/d95d2169d91b7d3d0f9c4b3752ccf425733ba7f6

Patch Set 1 #

Total comments: 4

Patch Set 2 : git cl try #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -72 lines) Patch
M README.chromium View 1 chunk +1 line, -1 line 0 comments Download
M include/libyuv/row.h View 1 1 chunk +8 lines, -8 lines 0 comments Download
M include/libyuv/version.h View 1 chunk +1 line, -1 line 0 comments Download
M source/convert_argb.cc View 1 23 chunks +25 lines, -25 lines 0 comments Download
M source/convert_from.cc View 1 8 chunks +8 lines, -8 lines 0 comments Download
M source/planar_functions.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M source/row_common.cc View 1 12 chunks +18 lines, -18 lines 0 comments Download
M source/row_neon.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M source/row_neon64.cc View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
fbarchard1
5 years, 1 month ago (2015-11-03 19:51:00 UTC) #1
harryjin
https://codereview.chromium.org/1429693006/diff/1/include/libyuv/row.h File include/libyuv/row.h (right): https://codereview.chromium.org/1429693006/diff/1/include/libyuv/row.h#newcode452 include/libyuv/row.h:452: extern const struct YuvConstants kYuvH709Constants; // BT.709 Silly question: ...
5 years, 1 month ago (2015-11-03 19:56:58 UTC) #2
fbarchard
Renamed the Yvu constants as well. https://codereview.chromium.org/1429693006/diff/1/include/libyuv/row.h File include/libyuv/row.h (right): https://codereview.chromium.org/1429693006/diff/1/include/libyuv/row.h#newcode452 include/libyuv/row.h:452: extern const struct ...
5 years, 1 month ago (2015-11-03 19:59:51 UTC) #4
harryjin
lgtm
5 years, 1 month ago (2015-11-04 00:48:03 UTC) #5
fbarchard1
5 years, 1 month ago (2015-11-04 01:09:57 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
d95d2169d91b7d3d0f9c4b3752ccf425733ba7f6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698