Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 1429683005: Replaced custom OrderedDict with collections.OrderedDict

Created:
5 years, 1 month ago by AWhetter
Modified:
3 years, 8 months ago
Reviewers:
methane
CC:
gyp-developer_googlegroups.com
Base URL:
https://chromium.googlesource.com/external/gyp.git@master
Target Ref:
refs/heads/master
Project:
gyp
Visibility:
Public.

Description

Replaced custom OrderedDict with collections.OrderedDict Now that python 2.7 is on all of the bots (see http://crbug.com/241769) there shouldn't be a need to keep using the custom implementation of OrderedDict that was added to maintain compatibility with older versions of python. Therefore this change removes the custom implementation and replaces it with collections.OrderedDict.

Patch Set 1 #

Patch Set 2 : Rebase with master (4ec6c4e3a94bd04a6da2858163d40b2429b8aad1) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -300 lines) Patch
M pylib/gyp/generator/msvs.py View 1 3 chunks +2 lines, -11 lines 0 comments Download
D pylib/gyp/ordered_dict.py View 1 chunk +0 lines, -289 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
AWhetter
5 years, 1 month ago (2015-11-06 20:36:55 UTC) #4
AWhetter
4 years, 8 months ago (2016-04-09 15:37:46 UTC) #5
methane
3 years, 8 months ago (2017-04-06 10:01:50 UTC) #7
lgtm

Powered by Google App Engine
This is Rietveld 408576698