Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1429653006: Remove flags for spread calls and arrays (Closed)

Created:
5 years, 1 month ago by adamk
Modified:
5 years, 1 month ago
Reviewers:
rossberg
CC:
v8-reviews_googlegroups.com, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove flags for spread calls and arrays These features shipped in M46 without issue. Committed: https://crrev.com/a4689fc21fdaf6ae623aab3db2511a952afc2768 Cr-Commit-Position: refs/heads/master@{#31635}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -3137 lines) Patch
M BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M src/bootstrapper.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +0 lines, -2 lines 0 comments Download
D src/js/harmony-spread.js View 1 chunk +0 lines, -56 lines 0 comments Download
A + src/js/spread.js View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/parser.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M src/preparser.h View 5 chunks +1 line, -12 lines 0 comments Download
M test/cctest/test-parsing.cc View 7 chunks +4 lines, -24 lines 0 comments Download
M test/js-perf-test/JSTests.json View 1 chunk +0 lines, -1 line 0 comments Download
A + test/mjsunit/es6/regress/regress-4298.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es6/regress/regress-4417.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es6/spread-array.js View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/es6/spread-call.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es6/spread-call-new.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es6/spread-call-new-class.js View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/es6/spread-call-super-property.js View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/es6/super.js View 1 chunk +1 line, -2 lines 0 comments Download
D test/mjsunit/harmony/regress/regress-4298.js View 1 chunk +0 lines, -8 lines 0 comments Download
D test/mjsunit/harmony/regress/regress-4417.js View 1 chunk +0 lines, -12 lines 0 comments Download
D test/mjsunit/harmony/spread-array.js View 1 chunk +0 lines, -179 lines 0 comments Download
D test/mjsunit/harmony/spread-call.js View 1 chunk +0 lines, -374 lines 0 comments Download
D test/mjsunit/harmony/spread-call-new.js View 1 chunk +0 lines, -62 lines 0 comments Download
D test/mjsunit/harmony/spread-call-new-class.js View 1 chunk +0 lines, -92 lines 0 comments Download
D test/mjsunit/harmony/spread-call-super-property.js View 1 chunk +0 lines, -31 lines 0 comments Download
D test/mjsunit/harmony/super.js View 1 chunk +0 lines, -2259 lines 0 comments Download
M test/mjsunit/strong/function-arity.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/strong/literals.js View 1 chunk +1 line, -1 line 0 comments Download
M tools/gyp/v8.gyp View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
adamk
5 years, 1 month ago (2015-10-28 00:54:34 UTC) #2
rossberg
lgtm
5 years, 1 month ago (2015-10-28 14:42:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1429653006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1429653006/1
5 years, 1 month ago (2015-10-28 15:55:29 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-28 15:57:06 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-10-28 15:57:37 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/a4689fc21fdaf6ae623aab3db2511a952afc2768
Cr-Commit-Position: refs/heads/master@{#31635}

Powered by Google App Engine
This is Rietveld 408576698