Issue 1429653004: Remove the mojo_use_application_in_sdk GN variable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1429653004: Remove the mojo_use_application_in_sdk GN variable. (Closed)

Created:
5 years, 1 month ago by viettrungluu

Modified:
5 years, 1 month ago

Reviewers:
jamesr

CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, darin (slow to review), gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+mojopublicwatch_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Remove the mojo_use_application_in_sdk GN variable. This basically reverts 074bd7376cfa07f424054f196f975c548c88d286. R=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/6f0b1256bad352e665a5b57e61757f33992325e9

Patch Set 1 #

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+76 lines, -106 lines)			Patch
M	mojo/edk/test/BUILD.gn	View	3 chunks	+6 lines, -12 lines	0 comments	Download
M	mojo/public/BUILD.gn	View	2 chunks	+4 lines, -15 lines	0 comments	Download
M	mojo/public/cpp/bindings/tests/BUILD.gn	View	2 chunks	+50 lines, -53 lines	0 comments	Download
M	mojo/public/java/BUILD.gn	View	3 chunks	+16 lines, -19 lines	0 comments	Download
M	mojo/public/mojo.gni	View	1 chunk	+0 lines, -7 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

viettrungluu

5 years, 1 month ago (2015-10-27 22:28:43 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
6f0b1256bad352e665a5b57e61757f33992325e9 (presubmit successful).

Expand Messages | Collapse Messages