Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(586)

Side by Side Diff: src/hydrogen-instructions.h

Issue 14296013: Unify canonicalization of HAdd/HSub/HMul a bit. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed feedback. Rebased. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/hydrogen-instructions.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 3824 matching lines...) Expand 10 before | Expand all | Expand 10 after
3835 } 3835 }
3836 } 3836 }
3837 3837
3838 virtual HType CalculateInferredType(); 3838 virtual HType CalculateInferredType();
3839 virtual Representation RequiredInputRepresentation(int index) { 3839 virtual Representation RequiredInputRepresentation(int index) {
3840 return index == 0 3840 return index == 0
3841 ? Representation::Tagged() 3841 ? Representation::Tagged()
3842 : representation(); 3842 : representation();
3843 } 3843 }
3844 3844
3845 virtual HValue* Canonicalize();
3846
3845 private: 3847 private:
3846 virtual bool IsDeletable() const { return true; } 3848 virtual bool IsDeletable() const { return true; }
3847 }; 3849 };
3848 3850
3849 3851
3850 class HCompareGeneric: public HBinaryOperation { 3852 class HCompareGeneric: public HBinaryOperation {
3851 public: 3853 public:
3852 HCompareGeneric(HValue* context, 3854 HCompareGeneric(HValue* context,
3853 HValue* left, 3855 HValue* left,
3854 HValue* right, 3856 HValue* right,
(...skipping 2635 matching lines...) Expand 10 before | Expand all | Expand 10 after
6490 virtual bool IsDeletable() const { return true; } 6492 virtual bool IsDeletable() const { return true; }
6491 }; 6493 };
6492 6494
6493 6495
6494 #undef DECLARE_INSTRUCTION 6496 #undef DECLARE_INSTRUCTION
6495 #undef DECLARE_CONCRETE_INSTRUCTION 6497 #undef DECLARE_CONCRETE_INSTRUCTION
6496 6498
6497 } } // namespace v8::internal 6499 } } // namespace v8::internal
6498 6500
6499 #endif // V8_HYDROGEN_INSTRUCTIONS_H_ 6501 #endif // V8_HYDROGEN_INSTRUCTIONS_H_
OLDNEW
« no previous file with comments | « no previous file | src/hydrogen-instructions.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698