Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Unified Diff: Source/WebCore/dom/Document.cpp

Issue 14296003: Remove TOUCH_EVENTS and TOUCH_EVENT_TRACKING compile-time flags. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/WebCore/dom/Document.cpp
diff --git a/Source/WebCore/dom/Document.cpp b/Source/WebCore/dom/Document.cpp
index f2cbc31188726b2148e16005b89ffb80c0f46f62..348e50049c9f2acd68edfe7b064b31860294b2a7 100644
--- a/Source/WebCore/dom/Document.cpp
+++ b/Source/WebCore/dom/Document.cpp
@@ -169,6 +169,7 @@
#include "TextAutosizer.h"
#include "TextResourceDecoder.h"
#include "Timer.h"
+#include "TouchList.h"
#include "TraceEvent.h"
#include "TransformSource.h"
#include "TreeWalker.h"
@@ -209,10 +210,6 @@
#include "SVGStyleElement.h"
#endif
-#if ENABLE(TOUCH_EVENTS)
-#include "TouchList.h"
-#endif
-
#if ENABLE(MATHML)
#include "MathMLElement.h"
#include "MathMLElementFactory.h"
@@ -557,10 +554,8 @@ Document::~Document()
if (m_templateDocument)
m_templateDocument->setTemplateDocumentHost(0); // balanced in templateDocument().
-#if ENABLE(TOUCH_EVENT_TRACKING)
if (Document* ownerDocument = this->ownerDocument())
ownerDocument->didRemoveEventTargetNode(this);
-#endif
// FIXME: Should we reset m_domWindow when we detach from the Frame?
if (m_domWindow)
m_domWindow->resetUnlessSuspendedForPageCache();
@@ -2013,10 +2008,8 @@ void Document::detach()
if (render)
render->destroy();
-#if ENABLE(TOUCH_EVENTS)
if (m_touchEventTargets && m_touchEventTargets->size() && parentDocument())
parentDocument()->didRemoveEventTargetNode(this);
-#endif
// This is required, as our Frame might delete itself as soon as it detaches
// us. However, this violates Node::detach() semantics, as it's never
@@ -5417,7 +5410,6 @@ void Document::serviceScriptedAnimations(double monotonicAnimationStartTime)
m_scriptedAnimationController->serviceScriptedAnimations(monotonicAnimationStartTime);
}
-#if ENABLE(TOUCH_EVENTS)
PassRefPtr<Touch> Document::createTouch(DOMWindow* window, EventTarget* target, int identifier, int pageX, int pageY, int screenX, int screenY, int radiusX, int radiusY, float rotationAngle, float force, ExceptionCode&) const
{
// FIXME: It's not clear from the documentation at
@@ -5427,7 +5419,6 @@ PassRefPtr<Touch> Document::createTouch(DOMWindow* window, EventTarget* target,
Frame* frame = window ? window->frame() : this->frame();
return Touch::create(frame, target, identifier, screenX, screenY, pageX, pageY, radiusX, radiusY, rotationAngle, force);
}
-#endif
static void wheelEventHandlerCountChanged(Document* document)
{
@@ -5469,7 +5460,6 @@ void Document::didRemoveWheelEventHandler()
void Document::didAddTouchEventHandler(Node* handler)
{
-#if ENABLE(TOUCH_EVENTS)
if (!m_touchEventTargets.get())
m_touchEventTargets = adoptPtr(new TouchEventTargetSet);
m_touchEventTargets->add(handler);
@@ -5478,21 +5468,15 @@ void Document::didAddTouchEventHandler(Node* handler)
return;
}
if (Page* page = this->page()) {
-#if ENABLE(TOUCH_EVENT_TRACKING)
if (ScrollingCoordinator* scrollingCoordinator = page->scrollingCoordinator())
scrollingCoordinator->touchEventTargetRectsDidChange(this);
-#endif
if (m_touchEventTargets->size() == 1)
page->chrome()->client()->needTouchEvents(true);
}
-#else
- UNUSED_PARAM(handler);
-#endif
}
void Document::didRemoveTouchEventHandler(Node* handler)
{
-#if ENABLE(TOUCH_EVENTS)
if (!m_touchEventTargets.get())
return;
ASSERT(m_touchEventTargets->contains(handler));
@@ -5505,10 +5489,8 @@ void Document::didRemoveTouchEventHandler(Node* handler)
Page* page = this->page();
if (!page)
return;
-#if ENABLE(TOUCH_EVENT_TRACKING)
if (ScrollingCoordinator* scrollingCoordinator = page->scrollingCoordinator())
scrollingCoordinator->touchEventTargetRectsDidChange(this);
-#endif
if (m_touchEventTargets->size())
return;
for (const Frame* frame = page->mainFrame(); frame; frame = frame->tree()->traverseNext()) {
@@ -5516,12 +5498,8 @@ void Document::didRemoveTouchEventHandler(Node* handler)
return;
}
page->chrome()->client()->needTouchEvents(false);
-#else
- UNUSED_PARAM(handler);
-#endif
}
-#if ENABLE(TOUCH_EVENTS)
void Document::didRemoveEventTargetNode(Node* handler)
{
if (m_touchEventTargets) {
@@ -5530,7 +5508,6 @@ void Document::didRemoveEventTargetNode(Node* handler)
parentDocument()->didRemoveEventTargetNode(this);
}
}
-#endif
void Document::resetLastHandledUserGestureTimestamp()
{
@@ -5846,9 +5823,7 @@ void Document::reportMemoryUsage(MemoryObjectInfo* memoryObjectInfo) const
info.addMember(m_viewportArguments, "viewportArguments");
info.addMember(m_documentTiming, "documentTiming");
info.addMember(m_mediaQueryMatcher, "mediaQueryMatcher");
-#if ENABLE(TOUCH_EVENTS)
info.addMember(m_touchEventTargets, "touchEventTargets");
-#endif
info.addMember(m_scriptedAnimationController, "scriptedAnimationController");
info.addMember(m_pendingTasksTimer, "pendingTasksTimer");
info.addMember(m_textAutosizer, "textAutosizer");

Powered by Google App Engine
This is Rietveld 408576698