Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issue 14296003: Remove TOUCH_EVENTS and TOUCH_EVENT_TRACKING compile-time flags. (Closed)

Created:
7 years, 8 months ago by Mike West
Modified:
7 years, 8 months ago
Reviewers:
eseidel
CC:
blink-reviews, caseq+blink_chromium.org, Nate Chapin, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, abarth-chromium, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, gavinp+loader_chromium.org, jchaffraix+rendering, darktears, haraken, aandrey+blink_chromium.org, jeez
Visibility:
Public.

Description

Remove TOUCH_EVENTS and TOUCH_EVENT_TRACKING compile-time flags. This mechanical patch should have no web-visible effect, as we enable both these flags everywhere we build Chromium. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=148646

Patch Set 1 #

Total comments: 2

Patch Set 2 : WebCore -> core. #

Patch Set 3 : space. #

Patch Set 4 : rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -378 lines) Patch
M Source/WebKit/chromium/features.gypi View 1 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebKit/chromium/src/ChromeClientImpl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/WebKit/chromium/src/ChromeClientImpl.cpp View 1 1 chunk +0 lines, -2 lines 0 comments Download
M Source/WebKit/chromium/src/PageWidgetDelegate.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/WebKit/chromium/src/PageWidgetDelegate.cpp View 1 3 chunks +0 lines, -4 lines 0 comments Download
M Source/WebKit/chromium/src/WebCompositorInputHandlerImpl.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/WebKit/chromium/src/WebInputEventConversion.h View 4 chunks +0 lines, -4 lines 0 comments Download
M Source/WebKit/chromium/src/WebInputEventConversion.cpp View 4 chunks +0 lines, -6 lines 0 comments Download
M Source/WebKit/chromium/src/WebPagePopupImpl.cpp View 1 1 chunk +0 lines, -2 lines 0 comments Download
M Source/WebKit/chromium/src/WebPopupMenuImpl.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/WebKit/chromium/src/WebRuntimeFeatures.cpp View 1 1 chunk +0 lines, -6 lines 0 comments Download
M Source/bindings/v8/RuntimeEnabledFeatures.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M Source/bindings/v8/custom/V8DocumentCustom.cpp View 1 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/css/CSSComputedStyleDeclaration.cpp View 1 2 chunks +0 lines, -4 lines 0 comments Download
M Source/core/css/CSSParser.cpp View 1 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/css/CSSProperty.cpp View 1 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/css/CSSPropertyNames.in View 1 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/css/StyleResolver.cpp View 1 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/dom/Document.h View 1 6 chunks +2 lines, -21 lines 0 comments Download
M Source/core/dom/Document.cpp View 1 12 chunks +1 line, -26 lines 0 comments Download
M Source/core/dom/Document.idl View 1 2 chunks +4 lines, -6 lines 0 comments Download
M Source/core/dom/Element.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/dom/Element.idl View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/dom/EventContext.h View 1 3 chunks +0 lines, -4 lines 0 comments Download
M Source/core/dom/EventContext.cpp View 1 2 chunks +0 lines, -3 lines 0 comments Download
M Source/core/dom/EventNames.in View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/EventRetargeter.h View 1 3 chunks +0 lines, -6 lines 0 comments Download
M Source/core/dom/EventRetargeter.cpp View 1 4 chunks +0 lines, -6 lines 0 comments Download
M Source/core/dom/Node.h View 1 2 chunks +0 lines, -5 lines 0 comments Download
M Source/core/dom/Node.cpp View 1 4 chunks +0 lines, -10 lines 0 comments Download
M Source/core/dom/Touch.h View 1 2 chunks +0 lines, -4 lines 0 comments Download
M Source/core/dom/Touch.cpp View 1 2 chunks +0 lines, -4 lines 0 comments Download
M Source/core/dom/Touch.idl View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/TouchEvent.h View 1 2 chunks +0 lines, -4 lines 0 comments Download
M Source/core/dom/TouchEvent.cpp View 1 2 chunks +0 lines, -4 lines 0 comments Download
M Source/core/dom/TouchEvent.idl View 1 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/dom/TouchList.h View 1 2 chunks +0 lines, -4 lines 0 comments Download
M Source/core/dom/TouchList.cpp View 1 2 chunks +0 lines, -4 lines 0 comments Download
M Source/core/dom/TouchList.idl View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/history/CachedFrame.cpp View 1 3 chunks +2 lines, -8 lines 0 comments Download
M Source/core/html/HTMLInputElement.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/html/HTMLInputElement.cpp View 1 8 chunks +1 line, -16 lines 0 comments Download
M Source/core/html/InputType.h View 1 2 chunks +0 lines, -4 lines 0 comments Download
M Source/core/html/InputType.cpp View 1 2 chunks +0 lines, -4 lines 0 comments Download
M Source/core/html/RangeInputType.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/html/RangeInputType.cpp View 1 3 chunks +3 lines, -8 lines 0 comments Download
M Source/core/inspector/InspectorPageAgent.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorPageAgent.cpp View 1 5 chunks +0 lines, -13 lines 0 comments Download
M Source/core/loader/EmptyClients.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/loader/FrameLoader.cpp View 1 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/page/ChromeClient.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/page/DOMWindow.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/page/DOMWindow.cpp View 1 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/page/DOMWindow.idl View 1 2 chunks +7 lines, -7 lines 0 comments Download
M Source/core/page/EventHandler.h View 1 4 chunks +1 line, -10 lines 0 comments Download
M Source/core/page/EventHandler.cpp View 1 13 chunks +3 lines, -24 lines 0 comments Download
M Source/core/page/Frame.cpp View 1 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/page/Settings.h View 1 2 chunks +0 lines, -4 lines 0 comments Download
M Source/core/page/Settings.cpp View 1 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/page/scrolling/ScrollingCoordinator.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/page/scrolling/ScrollingCoordinator.cpp View 1 5 chunks +0 lines, -6 lines 0 comments Download
M Source/core/platform/PlatformEvent.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/platform/PlatformTouchEvent.h View 1 2 chunks +0 lines, -4 lines 0 comments Download
M Source/core/platform/PlatformTouchPoint.h View 1 2 chunks +0 lines, -4 lines 0 comments Download
M Source/core/platform/chromium/FramelessScrollView.h View 1 2 chunks +0 lines, -4 lines 0 comments Download
M Source/core/platform/chromium/PopupContainer.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/platform/chromium/PopupContainer.cpp View 1 2 chunks +1 line, -6 lines 0 comments Download
M Source/core/platform/chromium/PopupListBox.h View 1 2 chunks +0 lines, -4 lines 0 comments Download
M Source/core/platform/chromium/PopupListBox.cpp View 1 3 chunks +1 line, -6 lines 0 comments Download
M Source/core/rendering/RenderTheme.h View 1 2 chunks +0 lines, -4 lines 0 comments Download
M Source/core/rendering/RenderTheme.cpp View 1 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderThemeChromiumAndroid.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderThemeChromiumSkia.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/rendering/style/RenderStyle.h View 1 3 chunks +0 lines, -6 lines 0 comments Download
M Source/core/rendering/style/RenderStyle.cpp View 1 2 chunks +0 lines, -4 lines 0 comments Download
M Source/core/rendering/style/StyleRareInheritedData.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/rendering/style/StyleRareInheritedData.cpp View 1 4 chunks +0 lines, -8 lines 0 comments Download
M Source/core/testing/InternalSettings.cpp View 1 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/testing/Internals.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/testing/Internals.cpp View 1 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/testing/Internals.idl View 1 1 chunk +0 lines, -2 lines 0 comments Download
M Source/wtf/FeatureDefines.h View 1 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Use mkwst_at_chromium.org plz.
Hello, Reviewers! Would you mind taking a look at this fairly mechanical patch? -mike
7 years, 8 months ago (2013-04-16 19:23:04 UTC) #1
eseidel
LGTM. https://codereview.chromium.org/14296003/diff/1/Source/WebCore/dom/Element.idl File Source/WebCore/dom/Element.idl (right): https://codereview.chromium.org/14296003/diff/1/Source/WebCore/dom/Element.idl#newcode202 Source/WebCore/dom/Element.idl:202: [NotEnumerable,EnabledAtRuntime=touch, PerWorldBindings] attribute EventListener ontouchstart; Missing a space. ...
7 years, 8 months ago (2013-04-16 19:31:14 UTC) #2
Mike West
Committed patchset #4 manually as r148646 (presubmit successful).
7 years, 8 months ago (2013-04-18 12:50:08 UTC) #3
Use mkwst_at_chromium.org plz.
7 years, 8 months ago (2013-04-18 12:50:53 UTC) #4
Message was sent while issue was closed.
On 2013/04/18 12:50:08, Mike West (chromium) wrote:
> Committed patchset #4 manually as r148646 (presubmit successful).

Rebased; bots are happy except for a test that looks unrelatedly flaky.

Powered by Google App Engine
This is Rietveld 408576698