Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Issue 1429523002: Safebrowsing check file extensions that open in IE. (Closed)

Created:
5 years, 1 month ago by mattm
Modified:
5 years, 1 month ago
Reviewers:
asanka, Ilya Sherman
CC:
grt+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Safebrowsing check file extensions that open in IE. Also add UMA values for some extra extensions. BUG=547908 Committed: https://crrev.com/d2bb418e1b9a3956e0efcdd0b0d78818872fa746 Cr-Commit-Position: refs/heads/master@{#357009}

Patch Set 1 #

Patch Set 2 : histograms, kDownloadFileTypes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -0 lines) Patch
M chrome/browser/download/download_extensions.cc View 1 8 chunks +45 lines, -0 lines 0 comments Download
M chrome/common/safe_browsing/download_protection_util.cc View 9 chunks +36 lines, -0 lines 0 comments Download
M content/browser/download/download_stats.cc View 1 1 chunk +18 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 chunks +36 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
mattm
Do you think any of these should go in download_extensions.cc too?
5 years, 1 month ago (2015-10-27 01:04:52 UTC) #2
asanka
Also update histograms.xml? I'd like to keep download_extensions in sync with this list, specially for ...
5 years, 1 month ago (2015-10-28 15:11:18 UTC) #3
mattm
On 2015/10/28 15:11:18, asanka wrote: > Also update histograms.xml? Oops, done. > I'd like to ...
5 years, 1 month ago (2015-10-28 22:48:00 UTC) #4
asanka
lgtm
5 years, 1 month ago (2015-10-29 02:31:43 UTC) #6
mattm
+isherman for histograms.xml
5 years, 1 month ago (2015-10-29 02:47:15 UTC) #8
Ilya Sherman
histograms.xml lgtm
5 years, 1 month ago (2015-10-29 22:33:12 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1429523002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1429523002/40001
5 years, 1 month ago (2015-10-29 23:31:08 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 1 month ago (2015-10-30 01:21:49 UTC) #13
commit-bot: I haz the power
5 years, 1 month ago (2015-10-30 01:22:32 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d2bb418e1b9a3956e0efcdd0b0d78818872fa746
Cr-Commit-Position: refs/heads/master@{#357009}

Powered by Google App Engine
This is Rietveld 408576698