Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Unified Diff: pkg/compiler/lib/src/cps_ir/scalar_replacement.dart

Issue 1429513006: dart2js CPS: Fix a bug in scalar replacement. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/cps_ir/scalar_replacement.dart
diff --git a/pkg/compiler/lib/src/cps_ir/scalar_replacement.dart b/pkg/compiler/lib/src/cps_ir/scalar_replacement.dart
index 0ff315c8627b47bcc8f7d86f91e8ecb4b59d7ed8..9d5ce4f637721efb4e60085ee4109ad7df48b290 100644
--- a/pkg/compiler/lib/src/cps_ir/scalar_replacement.dart
+++ b/pkg/compiler/lib/src/cps_ir/scalar_replacement.dart
@@ -18,7 +18,7 @@ import 'cps_ir_nodes.dart';
/**
* Replaces aggregates with a set of local values. Performs inlining of
- * single-use closures to generate more replacable aggregates.
+ * single-use closures to generate more replaceable aggregates.
*/
class ScalarReplacer extends Pass {
String get passName => 'Scalar replacement';
@@ -41,7 +41,7 @@ class ScalarReplacer extends Pass {
/**
* Do scalar replacement of aggregates on instances. Since scalar replacement
- * can create new candidiates, iterate until all scalar replacements are done.
+ * can create new candidates, iterate until all scalar replacements are done.
*/
class ScalarReplacementVisitor extends TrampolineRecursiveVisitor {
@@ -104,7 +104,8 @@ class ScalarReplacementVisitor extends TrampolineRecursiveVisitor {
(ClassElement enclosingClass, FieldElement field) {
Primitive argument = allocation.arguments[i++].definition;
fieldInitialValues[field] = argument;
- });
+ },
+ includeSuperAndInjectedMembers: true);
}
// Create [MutableVariable]s for each written field. Initialize the
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698