Issue 1429513006: dart2js CPS: Fix a bug in scalar replacement.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1429513006: dart2js CPS: Fix a bug in scalar replacement. (Closed)

Created:
5 years, 1 month ago by Kevin Millikin (Google)

Modified:
5 years, 1 month ago

Reviewers:
asgerf

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

dart2js CPS: Fix a bug in scalar replacement. Scalar replacement should compute initial values for all fields (including those in superclasses) because it will try to replace them. R=asgerf@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/73894d4d30439a44e0a50f790730264e27f5be00

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -3 lines)			Patch
	M	pkg/compiler/lib/src/cps_ir/scalar_replacement.dart	View		3 chunks	+4 lines, -3 lines	0 comments	Download

Total messages: 3 (0 generated)

Kevin Millikin (Google)

5 years, 1 month ago (2015-11-03 13:28:22 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
73894d4d30439a44e0a50f790730264e27f5be00 (presubmit successful).