Support new function subtyping rules in dart2js.

Support new function subtyping rules in dart2js.

BUG=http://dartbug.com/9058

Committed: https://code.google.com/p/dart/source/detail?r=22012

[karlklose, 2013-04-24 11:59:20]

LGTM.

https://codereview.chromium.org/14295018/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/dart_types.dart (right):

https://codereview.chromium.org/14295018/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/dart_types.dart:1021: //    
t.parameterTypes.length == s.parameterTypes.length
Perhaps you could define abbreviations for t/s.parameterTypes.length and
t/s.optionalParameterTypes.length to make the invariants easier to read.

https://codereview.chromium.org/14295018/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/dart_types.dart:1054: if
(!sps.isEmpty) {
It would be nicer to check the number of arguments invariants in one place, but
I guess we do not want to calculate the length of the links and then run through
them again.

https://codereview.chromium.org/14295018/diff/1/tests/compiler/dart2js/subtyp...
File tests/compiler/dart2js/subtype_test.dart (right):

https://codereview.chromium.org/14295018/diff/1/tests/compiler/dart2js/subtyp...
tests/compiler/dart2js/subtype_test.dart:368: void void___int_int_int([int i1,
int i2, int i3]);
This is not used, is it?

https://codereview.chromium.org/14295018/diff/1/tests/compiler/dart2js/subtyp...
tests/compiler/dart2js/subtype_test.dart:386: typedef void
void___int_int_int([int i1, int i2, int i3]);
Ditto.

[Johnni Winther, 2013-04-25 07:54:12]

https://codereview.chromium.org/14295018/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/dart_types.dart (right):

https://codereview.chromium.org/14295018/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/dart_types.dart:1021: //    
t.parameterTypes.length == s.parameterTypes.length
On 2013/04/24 11:59:20, karlklose wrote:
> Perhaps you could define abbreviations for t/s.parameterTypes.length and
> t/s.optionalParameterTypes.length to make the invariants easier to read.

Done.

https://codereview.chromium.org/14295018/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/dart_types.dart:1054: if
(!sps.isEmpty) {
On 2013/04/24 11:59:20, karlklose wrote:
> It would be nicer to check the number of arguments invariants in one place,
but
> I guess we do not want to calculate the length of the links and then run
through
> them again.

Added a TODO for a more readable implementation.

https://codereview.chromium.org/14295018/diff/1/tests/compiler/dart2js/subtyp...
File tests/compiler/dart2js/subtype_test.dart (right):

https://codereview.chromium.org/14295018/diff/1/tests/compiler/dart2js/subtyp...
tests/compiler/dart2js/subtype_test.dart:368: void void___int_int_int([int i1,
int i2, int i3]);
On 2013/04/24 11:59:20, karlklose wrote:
> This is not used, is it?

Done.

https://codereview.chromium.org/14295018/diff/1/tests/compiler/dart2js/subtyp...
tests/compiler/dart2js/subtype_test.dart:386: typedef void
void___int_int_int([int i1, int i2, int i3]);
On 2013/04/24 11:59:20, karlklose wrote:
> Ditto.

Done.

[Johnni Winther, 2013-04-25 07:55:19]

Committed patchset #2 manually as r22012 (presubmit successful).