Simple Cache: DoomEntriesBetween()

net/disk_cache/simple/simple_entry_impl.cc

Index: net/disk_cache/simple/simple_entry_impl.cc
diff --git a/net/disk_cache/simple/simple_entry_impl.cc b/net/disk_cache/simple/simple_entry_impl.cc
index 1917a88715091ac1a37be9dae3b8fd104b6f4edf..e499de15c24eb2e6bca913fdbcf97569fc5b281f 100644
--- a/net/disk_cache/simple/simple_entry_impl.cc
+++ b/net/disk_cache/simple/simple_entry_impl.cc
@@ -41,18 +41,15 @@ int SimpleEntryImpl::OpenEntry(WeakPtr<SimpleIndex> index,
                                const CompletionCallback& callback) {
   // TODO(gavinp): More closely unify the last_used_ in the
   // SimpleSynchronousEntry  and the SimpleIndex.
-  if (!index || index->UseIfExists(key)) {

[felipeg, 2013/04/17 16:35:04]

please keep this
and use the method index->Has(key) instead

[pasko-google - do not use, 2013/04/17 19:47:52]

Oh yes, that's the whole purpose of the index: quickly answer if we do not have
stuff.

I inverted the condition since it looks nicer that way, also removed the
TODO(gavinp) above since we have basically the same TODO(felipeg) below in a
more relevant place.

Done.

This reminds me of stale index (not knowing about new entries added), that would
fail the open, which may be not ideal for offline reading. Detecting a stale
index is not trivial, so I would not even add a TODO for adding a histogram
here. Thanks, now I have a creepy feeling that is not easy to fix.

[felipeg, 2013/04/18 09:54:59]

A stale and valid index (with the correct file entries and CRC) should be really
really rare.
And our garbage collector will take care of getting rid of it from time to time.
(I am working in the GC CL).

And I strongly suggest we have a histogram here, we need numbers to justify
having the index.

-    SynchronousCreationCallback sync_creation_callback =
-        base::Bind(&SimpleEntryImpl::CreationOperationComplete,
-                   index, callback, key, entry);
-    WorkerPool::PostTask(FROM_HERE,
-                         base::Bind(&SimpleSynchronousEntry::OpenEntry, path,
-                                    key, MessageLoopProxy::current(),
-                                    sync_creation_callback),
-                         true);
-    return net::ERR_IO_PENDING;
-  }
-  return net::ERR_FAILED;
+  SynchronousCreationCallback sync_creation_callback =
+      base::Bind(&SimpleEntryImpl::CreationOperationComplete,
+                 index, callback, key, entry);
+  WorkerPool::PostTask(FROM_HERE,
+                       base::Bind(&SimpleSynchronousEntry::OpenEntry, path,
+                                  key, MessageLoopProxy::current(),
+                                  sync_creation_callback),
+                       true);
+  return net::ERR_IO_PENDING;
 }
 
 // static