Issue 14295012: Revert 194347

Issue 14295012: Revert 194347 (Closed)

Created:
7 years, 8 months ago by cpu_(ooo_6.6-7.5)

Modified:
7 years, 8 months ago

Reviewers:
felipeg_google, felipeg

CC:
chromium-reviews, cbentzel+watch_chromium.org, gavinp+disk_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 194347 It broke linux compile http://build.chromium.org/p/chromium.chrome/buildstatus?builder=Google%20Chrome%20Linux&number=29552 > Refactor our SimpleIndex file format and serialization to use Pickle instead of the previously buggy way of writing uninitialized structs and ints into the file. > > BUG=230772 > > Review URL: https://codereview.chromium.org/14263005 TBR=felipeg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194373

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+226 lines, -792 lines)			Patch
M	net/disk_cache/backend_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
A +	net/disk_cache/simple/simple_disk_format.h	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	net/disk_cache/simple/simple_disk_format.cc	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
D	net/disk_cache/simple/simple_entry_format.h	View	1 chunk	+0 lines, -38 lines	0 comments	Download
D	net/disk_cache/simple/simple_entry_format.cc	View	1 chunk	+0 lines, -16 lines	0 comments	Download
M	net/disk_cache/simple/simple_entry_impl.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/disk_cache/simple/simple_index.h	View	2 chunks	+28 lines, -58 lines	0 comments	Download
M	net/disk_cache/simple/simple_index.cc	View	10 chunks	+192 lines, -107 lines	0 comments	Download
D	net/disk_cache/simple/simple_index_file.h	View	1 chunk	+0 lines, -92 lines	0 comments	Download
D	net/disk_cache/simple/simple_index_file.cc	View	1 chunk	+0 lines, -164 lines	0 comments	Download
D	net/disk_cache/simple/simple_index_file_unittest.cc	View	1 chunk	+0 lines, -92 lines	0 comments	Download
D	net/disk_cache/simple/simple_index_unittest.cc	View	1 chunk	+0 lines, -95 lines	0 comments	Download
M	net/disk_cache/simple/simple_synchronous_entry.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/disk_cache/simple/simple_util.h	View	1 chunk	+0 lines, -17 lines	0 comments	Download
M	net/disk_cache/simple/simple_util.cc	View	1 chunk	+3 lines, -40 lines	0 comments	Download
D	net/disk_cache/simple/simple_util_unittest.cc	View	1 chunk	+0 lines, -65 lines	0 comments	Download
M	net/net.gyp	View	2 chunks	+2 lines, -7 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux/builds/29552 You probably need the numbers to be ULL instead of UL?

7 years, 8 months ago (2013-04-16 17:21:17 UTC) #3

felipeg_google

7 years, 8 months ago (2013-04-16 17:24:14 UTC) #4

I need to use this macro: GG_UINT64_C
from base/port.h

thanks
:)
https://codereview.chromium.org/14263005/diff2/42004:39012/net/disk_cache/sim...


On Tue, Apr 16, 2013 at 7:21 PM, <thestig@chromium.org> wrote:

> http://build.chromium.org/p/**chromium.chrome/builders/**
>
Google%20Chrome%20Linux/**builds/29552<http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux/builds/29552>
>
> You probably need the numbers to be ULL instead of UL?
>
>
https://codereview.chromium.**org/14295012/<https://codereview.chromium.org/1...
>

Expand Messages | Collapse Messages