Fix widget.dart to work with the latest web_ui library. Specifically, query selectors need to use "…

Fix widget.dart to work with the latest web_ui library. Specifically, query selectors need to use "[is=x-foo]" instead of "x-foo" and components cannot be assumed to subclass UnknownElement.
Fix warnings due to missing constructor="ClassName" attributes.


BUG=

[Jacob, 2013-04-16 15:30:18]

Fix widget.dart to work with the latest web_ui library.
Specifically, query selectors need to use "[is=x-foo]" instead of "x-foo" and
components cannot be assumed to subclass UnknownElement.

[Siggi Cherem (dart-lang), 2013-04-16 17:07:20]

some quick drive-by-comments about versions

https://chromiumcodereview.appspot.com/14295009/diff/3001/pubspec.yaml
File pubspec.yaml (right):

https://chromiumcodereview.appspot.com/14295009/diff/3001/pubspec.yaml#newcode2
pubspec.yaml:2: version: 0.4.7
Please change the new version to "0.2.5" or "0.3.0" if this is a major revision
change.

Note that it is not always possible to keep versions in sync, and we actually
don't try to use the same version number as the SDK. For example, if we make
more breaking changes in our own package, we have to keep increasing version
numbers on each release and we'll likely be ahead of the SDK version.

https://chromiumcodereview.appspot.com/14295009/diff/3001/pubspec.yaml#newcode7
pubspec.yaml:7: sdk: '>=0.4.5'
use 0.4.7

https://chromiumcodereview.appspot.com/14295009/diff/3001/pubspec.yaml#newcode10
pubspec.yaml:10: web_ui: '>=0.4.5'
use 0.4.6+1

https://chromiumcodereview.appspot.com/14295009/diff/3001/pubspec.yaml#newcode11
pubspec.yaml:11: html5lib: '>=0.4.3 <0.4.4'
is this imported explicitly in the code? if not, we might not need the
dependency altogether.

[Jacob, 2013-04-16 17:18:19]

ptal

https://chromiumcodereview.appspot.com/14295009/diff/3001/pubspec.yaml
File pubspec.yaml (right):

https://chromiumcodereview.appspot.com/14295009/diff/3001/pubspec.yaml#newcode2
pubspec.yaml:2: version: 0.4.7
On 2013/04/16 17:07:20, Siggi Cherem (dart-lang) wrote:
> Please change the new version to "0.2.5" or "0.3.0" if this is a major
revision
> change.
> 
> Note that it is not always possible to keep versions in sync, and we actually
> don't try to use the same version number as the SDK. For example, if we make
> more breaking changes in our own package, we have to keep increasing version
> numbers on each release and we'll likely be ahead of the SDK version. 

Done.

https://chromiumcodereview.appspot.com/14295009/diff/3001/pubspec.yaml#newcode7
pubspec.yaml:7: sdk: '>=0.4.5'
On 2013/04/16 17:07:20, Siggi Cherem (dart-lang) wrote:
> use 0.4.7

Done.

https://chromiumcodereview.appspot.com/14295009/diff/3001/pubspec.yaml#newcode10
pubspec.yaml:10: web_ui: '>=0.4.5'
On 2013/04/16 17:07:20, Siggi Cherem (dart-lang) wrote:
> use 0.4.6+1

Done.

https://chromiumcodereview.appspot.com/14295009/diff/3001/pubspec.yaml#newcode11
pubspec.yaml:11: html5lib: '>=0.4.3 <0.4.4'
On 2013/04/16 17:07:20, Siggi Cherem (dart-lang) wrote:
> is this imported explicitly in the code? if not, we might not need the
> dependency altogether.
It doesn't seem like it was needed. Removed.

[Siggi Cherem (dart-lang), 2013-04-16 17:34:36]

lgtm

Thanks Jacob!

https://chromiumcodereview.appspot.com/14295009/diff/7001/changelog.md
File changelog.md (right):

https://chromiumcodereview.appspot.com/14295009/diff/7001/changelog.md#newcode5
changelog.md:5: Updated to lastest web_ui. Aligned version numbers with SDK
versions for simpler
now that we switched back, we should remove the comment about version numbers.

https://chromiumcodereview.appspot.com/14295009/diff/7001/lib/components/acco...
File lib/components/accordion.dart (right):

https://chromiumcodereview.appspot.com/14295009/diff/7001/lib/components/acco...
lib/components/accordion.dart:29: List<Element> _getAllCollapseElements() =>
this.queryAll('[is=x-accordion] > [is=x-collapse]');
long line (the original code was already like that though)

https://chromiumcodereview.appspot.com/14295009/diff/7001/lib/components/acco...
lib/components/accordion.dart:33: if(target.xtag is ShowHideComponent) {
style nit: space after 'if' (although seems like this is common in this package,
so feel free to skip)

https://chromiumcodereview.appspot.com/14295009/diff/7001/lib/components/caro...
File lib/components/carousel.dart (right):

https://chromiumcodereview.appspot.com/14295009/diff/7001/lib/components/caro...
lib/components/carousel.dart:28: SwapComponent get _swap =>
this.query('[is=x-carousel] > .carousel > [is=x-swap]').xtag;
long line

[Jacob, 2013-04-16 17:45:46]

ptal

https://chromiumcodereview.appspot.com/14295009/diff/7001/changelog.md
File changelog.md (right):

https://chromiumcodereview.appspot.com/14295009/diff/7001/changelog.md#newcode5
changelog.md:5: Updated to lastest web_ui. Aligned version numbers with SDK
versions for simpler
On 2013/04/16 17:34:36, Siggi Cherem (dart-lang) wrote:
> now that we switched back, we should remove the comment about version numbers.


Done.

https://chromiumcodereview.appspot.com/14295009/diff/7001/lib/components/acco...
File lib/components/accordion.dart (right):

https://chromiumcodereview.appspot.com/14295009/diff/7001/lib/components/acco...
lib/components/accordion.dart:29: List<Element> _getAllCollapseElements() =>
this.queryAll('[is=x-accordion] > [is=x-collapse]');
On 2013/04/16 17:34:36, Siggi Cherem (dart-lang) wrote:
> long line (the original code was already like that though)

Done.

https://chromiumcodereview.appspot.com/14295009/diff/7001/lib/components/acco...
lib/components/accordion.dart:29: List<Element> _getAllCollapseElements() =>
this.queryAll('[is=x-accordion] > [is=x-collapse]');
On 2013/04/16 17:34:36, Siggi Cherem (dart-lang) wrote:
> long line (the original code was already like that though)

Done.

https://chromiumcodereview.appspot.com/14295009/diff/7001/lib/components/acco...
lib/components/accordion.dart:33: if(target.xtag is ShowHideComponent) {
On 2013/04/16 17:34:36, Siggi Cherem (dart-lang) wrote:
> style nit: space after 'if' (although seems like this is common in this
package,
> so feel free to skip)

Fixed.  When we touch a file we should make it more closely match the style
guide.

https://chromiumcodereview.appspot.com/14295009/diff/7001/lib/components/caro...
File lib/components/carousel.dart (right):

https://chromiumcodereview.appspot.com/14295009/diff/7001/lib/components/caro...
lib/components/carousel.dart:28: SwapComponent get _swap =>
this.query('[is=x-carousel] > .carousel > [is=x-swap]').xtag;
On 2013/04/16 17:34:36, Siggi Cherem (dart-lang) wrote:
> long line

Done.

[Siggi Cherem (dart-lang), 2013-04-16 18:01:13]

lgtm - probably Kevin needs to submit this (maybe create a pull request on
github?)

[kevmoo-old, 2013-04-18 16:18:43]

We can close this, right? All merged...

[Siggi Cherem (dart-lang), 2013-04-18 18:42:50]

yeah, thanks! - just closed it manually