Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Issue 14295007: Remove the CSS_COMPOSITING define, the CSS blending and compositing (Closed)

Created:
7 years, 8 months ago by mitica
Modified:
7 years, 7 months ago
Reviewers:
eseidel
CC:
blink-reviews
Base URL:
http://src.chromium.org/blink/trunk/Source/
Visibility:
Public.

Description

Remove the CSS_COMPOSITING define, the CSS blending and compositing implementation is currently under a runtime guard. BUG: 229926

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -83 lines) Patch
M WTF/wtf/FeatureDefines.h View 1 chunk +0 lines, -4 lines 0 comments Download
M WebCore/css/CSSComputedStyleDeclaration.cpp View 3 chunks +0 lines, -4 lines 0 comments Download
M WebCore/css/CSSParser.cpp View 7 chunks +0 lines, -10 lines 0 comments Download
M WebCore/css/CSSProperty.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M WebCore/css/StyleBuilder.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M WebCore/rendering/RenderLayer.h View 3 chunks +0 lines, -8 lines 0 comments Download
M WebCore/rendering/RenderLayer.cpp View 6 chunks +0 lines, -10 lines 0 comments Download
M WebCore/rendering/RenderLayerBacking.h View 2 chunks +0 lines, -4 lines 0 comments Download
M WebCore/rendering/RenderLayerBacking.cpp View 4 chunks +0 lines, -8 lines 0 comments Download
M WebCore/rendering/RenderLayerCompositor.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M WebCore/rendering/RenderObject.h View 1 chunk +0 lines, -4 lines 0 comments Download
M WebCore/rendering/style/RenderStyle.h View 2 chunks +0 lines, -6 lines 0 comments Download
M WebCore/rendering/style/RenderStyle.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M WebCore/rendering/style/StyleRareNonInheritedData.h View 1 chunk +0 lines, -2 lines 0 comments Download
M WebCore/rendering/style/StyleRareNonInheritedData.cpp View 3 chunks +0 lines, -6 lines 0 comments Download
M WebKit/chromium/features.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M bindings/v8/RuntimeEnabledFeatures.h View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
eseidel
Isn't this detectable from the Web?
7 years, 8 months ago (2013-04-16 21:48:52 UTC) #1
ojan
On 2013/04/16 21:48:52, Eric Seidel (Google) wrote: > Isn't this detectable from the Web? FWIW, ...
7 years, 8 months ago (2013-04-17 00:03:53 UTC) #2
eseidel
To answer my own question: yes this is detectable from the web. We need to ...
7 years, 8 months ago (2013-04-17 00:20:05 UTC) #3
jamesr
On 2013/04/17 00:20:05, Eric Seidel (Google) wrote: > To answer my own question: yes this ...
7 years, 8 months ago (2013-04-17 00:52:00 UTC) #4
eseidel
7 years, 8 months ago (2013-04-17 01:40:18 UTC) #5
It's currently impossible to guard CSS properties at runtime.  It's possible to
guard CSS values if done carefully.

Powered by Google App Engine
This is Rietveld 408576698