Re-enable a few find in page tests.

chrome/browser/ui/views/find_bar_host_interactive_uitest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/process_util.h"
 #include "base/string_util.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_commands.h"
 #include "chrome/browser/ui/browser_tabstrip.h"
@@ skipping 13 matching lines @@
 #include "ui/base/clipboard/clipboard.h"
 #include "ui/base/keycodes/keyboard_codes.h"
 #include "ui/views/focus/focus_manager.h"
 #include "ui/views/view.h"
 #include "ui/views/views_delegate.h"
 
 using content::WebContents;
 
 namespace {
 
-// The delay waited after sending an OS simulated event.
-static const int kActionDelayMs = 500;
 static const char kSimplePage[] = "files/find_in_page/simple.html";
 
-void Checkpoint(const char* message, const base::TimeTicks& start_time) {
-  LOG(INFO) << message << " : "
-    << (base::TimeTicks::Now() - start_time).InMilliseconds()
-    << " ms" << std::flush;
-}
-
 class FindInPageTest : public InProcessBrowserTest {
  public:
   FindInPageTest() {
     FindBarHost::disable_animations_during_testing_ = true;
   }
 
   string16 GetFindBarText() {
     FindBarTesting* find_bar =
         browser()->GetFindBarController()->find_bar()->GetFindBarTesting();
     return find_bar->GetFindText();
   }
 
   string16 GetFindBarSelectedText() {
     FindBarTesting* find_bar =
         browser()->GetFindBarController()->find_bar()->GetFindBarTesting();
     return find_bar->GetFindSelectedText();
   }
 
  private:
   DISALLOW_COPY_AND_ASSIGN(FindInPageTest);
 };
 
 }  // namespace
 
-// Fails often on Win, CrOS. http://crbug.com/145476, http://crbug.com/128724

[msw, 2013/04/18 16:11:57]

http://crbug.com/145476 looks related, but I'm not sure that
http://crbug.com/128724 is related, no one posted copies of the failure logs...

[Finnur, 2013/04/19 10:55:45]

Yeah, it is hard to say. There was a suspected CL mentioned and a followup CL
that, if I recall, fixed the problem(s) and re-enabled some of the tests. Since
there's no debug info we might as well enable this and see what happens.

-#if defined(OS_WIN) || defined(OS_CHROMEOS)
-#define MAYBE_CrashEscHandlers DISABLED_CrashEscHandlers
-#else
-#define MAYBE_CrashEscHandlers CrashEscHandlers
-#endif
-IN_PROC_BROWSER_TEST_F(FindInPageTest, MAYBE_CrashEscHandlers) {
+// Flaky because the test server fails to start? See: http://crbug.com/96594.
+IN_PROC_BROWSER_TEST_F(FindInPageTest, CrashEscHandlers) {
   ASSERT_TRUE(test_server()->Start());
 
   // First we navigate to our test page (tab A).
   GURL url = test_server()->GetURL(kSimplePage);
   ui_test_utils::NavigateToURL(browser(), url);
 
   chrome::Find(browser());
 
   // Open another tab (tab B).
   chrome::AddSelectedTabWithURL(browser(), url, content::PAGE_TRANSITION_TYPED);
@@ skipping 13 matching lines @@
   ASSERT_NO_FATAL_FAILURE(ui_test_utils::ClickOnView(browser(),
                                                      VIEW_ID_OMNIBOX));
   // Check the location bar is focused.
   EXPECT_TRUE(ui_test_utils::IsViewFocused(browser(), VIEW_ID_OMNIBOX));
 
   // This used to crash until bug 1303709 was fixed.
   ASSERT_TRUE(ui_test_utils::SendKeyPressSync(
       browser(), ui::VKEY_ESCAPE, false, false, false, false));
 }
 
-// Fails to start the test server on ChromeOS: http://crbug.com/168974
-#if defined(OS_CHROMEOS)
-#define MAYBE_FocusRestore DISABLED_FocusRestore
-#else
-#define MAYBE_FocusRestore FocusRestore
-#endif
-IN_PROC_BROWSER_TEST_F(FindInPageTest, MAYBE_FocusRestore) {
+// Flaky because the test server fails to start? See: http://crbug.com/96594.
+IN_PROC_BROWSER_TEST_F(FindInPageTest, FocusRestore) {
   ASSERT_TRUE(test_server()->Start());
 
   GURL url = test_server()->GetURL("title1.html");
   ui_test_utils::NavigateToURL(browser(), url);
 
   // Focus the location bar, open and close the find-in-page, focus should
   // return to the location bar.
   chrome::FocusLocationBar(browser());
   EXPECT_TRUE(ui_test_utils::IsViewFocused(browser(), VIEW_ID_OMNIBOX));
   // Ensure the creation of the find bar controller.
@@ skipping 26 matching lines @@
   EXPECT_TRUE(ui_test_utils::IsViewFocused(browser(), VIEW_ID_OMNIBOX));
   browser()->GetFindBarController()->Show();
   EXPECT_TRUE(ui_test_utils::IsViewFocused(browser(),
                                            VIEW_ID_FIND_IN_PAGE_TEXT_FIELD));
   browser()->GetFindBarController()->EndFindSession(
       FindBarController::kKeepSelectionOnPage,
       FindBarController::kKeepResultsInFindBox);
   EXPECT_TRUE(ui_test_utils::IsViewFocused(browser(), VIEW_ID_OMNIBOX));
 }
 
-// Fails often on Win, CrOS. http://crbug.com/145476, http://crbug.com/128724
-#if defined(OS_WIN) || defined(OS_CHROMEOS)
-#define MAYBE_FocusRestoreOnTabSwitch DISABLED_FocusRestoreOnTabSwitch
-#else
-#define MAYBE_FocusRestoreOnTabSwitch FocusRestoreOnTabSwitch
-#endif
-IN_PROC_BROWSER_TEST_F(FindInPageTest, MAYBE_FocusRestoreOnTabSwitch) {
+// Flaky because the test server fails to start? See: http://crbug.com/96594.
+IN_PROC_BROWSER_TEST_F(FindInPageTest, FocusRestoreOnTabSwitch) {
   ASSERT_TRUE(test_server()->Start());
 
   // First we navigate to our test page (tab A).
   GURL url = test_server()->GetURL(kSimplePage);
   ui_test_utils::NavigateToURL(browser(), url);
 
   chrome::Find(browser());
   EXPECT_TRUE(ui_test_utils::IsViewFocused(browser(),
                                            VIEW_ID_FIND_IN_PAGE_TEXT_FIELD));
 
@@ skipping 32 matching lines @@
   browser()->tab_strip_model()->ActivateTabAt(0, true);
   EXPECT_TRUE(ui_test_utils::IsViewFocused(browser(),
                                            VIEW_ID_FIND_IN_PAGE_TEXT_FIELD));
   EXPECT_TRUE(ASCIIToUTF16("a") == find_bar->GetFindSelectedText());
 
   // Select tab B. Location bar should get focus.
   browser()->tab_strip_model()->ActivateTabAt(1, true);
   EXPECT_TRUE(ui_test_utils::IsViewFocused(browser(), VIEW_ID_OMNIBOX));
 }
 
-// Flaky on XP: http://crbug.com/152100

[msw, 2013/04/18 16:11:57]

http://crbug.com/152100 doesn't look related.

[Finnur, 2013/04/19 10:55:45]

Remember when you said you couldn't repro the flakiness on your box? Well, I
could repro it consistently (it wasn't even flakiness, it was a consistent
failure). But when I matched what you did (reinstating reverted SearchTextfield
class), I stopped being able to repro.

-// Flaky on ChromiumOS: http://crbug.com/177487
-#if defined(OS_WIN) || defined(OS_CHROMEOS)
-#define MAYBE_PrepopulateRespectBlank DISABLED_PrepopulateRespectBlank
-#else
-#define MAYBE_PrepopulateRespectBlank PrepopulateRespectBlank
-#endif
+// Flaky because the test server fails to start? See: http://crbug.com/96594.
 // This tests that whenever you clear values from the Find box and close it that
 // it respects that and doesn't show you the last search, as reported in bug:
 // http://crbug.com/40121.
-IN_PROC_BROWSER_TEST_F(FindInPageTest, MAYBE_PrepopulateRespectBlank) {
+IN_PROC_BROWSER_TEST_F(FindInPageTest, PrepopulateRespectBlank) {
 #if defined(OS_MACOSX)
   // FindInPage on Mac doesn't use prepopulated values. Search there is global.
   return;
 #endif
-  base::TimeTicks start_time = base::TimeTicks::Now();
-  Checkpoint("Test starting", start_time);
-
   ASSERT_TRUE(test_server()->Start());
 
   // Make sure Chrome is in the foreground, otherwise sending input
   // won't do anything and the test will hang.
   ASSERT_TRUE(ui_test_utils::BringBrowserWindowToFront(browser()));
 
-  Checkpoint("Navigate", start_time);
-
   // First we navigate to any page.
   GURL url = test_server()->GetURL(kSimplePage);
   ui_test_utils::NavigateToURL(browser(), url);
 
-  Checkpoint("Show Find bar", start_time);
-
   // Show the Find bar.
   browser()->GetFindBarController()->Show();
 
-  Checkpoint("Search for 'a'", start_time);
-
   // Search for "a".
   ASSERT_TRUE(ui_test_utils::SendKeyPressSync(
       browser(), ui::VKEY_A, false, false, false, false));
 
   // We should find "a" here.
   EXPECT_EQ(ASCIIToUTF16("a"), GetFindBarText());
 
-  Checkpoint("Delete 'a'", start_time);
-
   // Delete "a".
   ASSERT_TRUE(ui_test_utils::SendKeyPressSync(
       browser(), ui::VKEY_BACK, false, false, false, false));
 
   // Validate we have cleared the text.
   EXPECT_EQ(string16(), GetFindBarText());
 
-  Checkpoint("Close find bar", start_time);
-
   // Close the Find box.
   ASSERT_TRUE(ui_test_utils::SendKeyPressSync(
       browser(), ui::VKEY_ESCAPE, false, false, false, false));
 
-  Checkpoint("Show Find bar", start_time);
-
   // Show the Find bar.
   browser()->GetFindBarController()->Show();
 
-  Checkpoint("Validate text", start_time);
-
   // After the Find box has been reopened, it should not have been prepopulated
   // with "a" again.
   EXPECT_EQ(string16(), GetFindBarText());
 
-  Checkpoint("Close Find bar", start_time);
-
   // Close the Find box.
   ASSERT_TRUE(ui_test_utils::SendKeyPressSync(
       browser(), ui::VKEY_ESCAPE, false, false, false, false));
 
-  Checkpoint("FindNext", start_time);
-
   // Press F3 to trigger FindNext.
   ASSERT_TRUE(ui_test_utils::SendKeyPressSync(
       browser(), ui::VKEY_F3, false, false, false, false));
 
-  Checkpoint("Validate", start_time);
-
   // After the Find box has been reopened, it should still have no prepopulate
   // value.
   EXPECT_EQ(string16(), GetFindBarText());
-
-  Checkpoint("Test done", start_time);
 }
 
 // Flaky on Win. http://crbug.com/92467
 // Flaky on ChromeOS. http://crbug.com/118216
 #if defined(OS_WIN) || defined(OS_CHROMEOS)
 #define MAYBE_PasteWithoutTextChange DISABLED_PasteWithoutTextChange
 #else
 #define MAYBE_PasteWithoutTextChange PasteWithoutTextChange
 #endif
 
@@ skipping 53 matching lines @@
           chrome::NOTIFICATION_FIND_RESULT_AVAILABLE, notification_source);
 
   ASSERT_TRUE(ui_test_utils::SendKeyPressSync(
       browser(), ui::VKEY_V, true, false, false, false));
 
   ASSERT_NO_FATAL_FAILURE(observer.Wait());
   FindNotificationDetails details;
   ASSERT_TRUE(observer.GetDetailsFor(notification_source.map_key(), &details));
   EXPECT_TRUE(details.number_of_matches() > 0);
 }