Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1030)

Issue 14294009: Revert the commits adding new GC-related APIs. (Closed)

Created:
7 years, 8 months ago by marja
Modified:
7 years, 8 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
git://github.com/v8/v8.git@master
Visibility:
Public.

Description

Revert the commits adding new GC-related APIs. We need to solve efficiency problems first. This reverts the following revisions: 14283 14286 14221 14215 BUG= Committed: http://code.google.com/p/v8/source/detail?r=14293

Patch Set 1 #

Patch Set 2 : remove test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+167 lines, -1017 lines) Patch
M include/v8.h View 4 chunks +0 lines, -54 lines 0 comments Download
M src/api.cc View 2 chunks +0 lines, -37 lines 0 comments Download
M src/global-handles.h View 5 chunks +55 lines, -85 lines 0 comments Download
M src/global-handles.cc View 4 chunks +45 lines, -113 lines 0 comments Download
M src/heap-snapshot-generator.cc View 2 chunks +27 lines, -90 lines 0 comments Download
M src/mark-compact.cc View 1 chunk +25 lines, -63 lines 0 comments Download
M test/cctest/test-api.cc View 7 chunks +5 lines, -313 lines 0 comments Download
M test/cctest/test-global-handles.cc View 1 2 chunks +0 lines, -113 lines 0 comments Download
M test/cctest/test-heap-profiler.cc View 2 chunks +6 lines, -27 lines 0 comments Download
M test/cctest/test-mark-compact.cc View 6 chunks +4 lines, -122 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
marja
ptal
7 years, 8 months ago (2013-04-16 15:10:46 UTC) #1
Michael Starzinger
LGTM (rubber-stamped). I'll land this.
7 years, 8 months ago (2013-04-16 15:36:19 UTC) #2
Michael Starzinger
7 years, 8 months ago (2013-04-16 16:37:19 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r14293 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698