Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(968)

Unified Diff: Source/core/inspector/InspectorDebuggerAgent.cpp

Issue 14294004: Implementing console command 'debug'. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/inspector/InspectorDebuggerAgent.cpp
diff --git a/Source/core/inspector/InspectorDebuggerAgent.cpp b/Source/core/inspector/InspectorDebuggerAgent.cpp
index 35a4996064fd02f3a4396933829c26049d825cc8..7318518c681870dccecfe70452f99790bfbb34e0 100644
--- a/Source/core/inspector/InspectorDebuggerAgent.cpp
+++ b/Source/core/inspector/InspectorDebuggerAgent.cpp
@@ -61,6 +61,11 @@ static const char pauseOnExceptionsState[] = "pauseOnExceptionsState";
const char* InspectorDebuggerAgent::backtraceObjectGroup = "backtrace";
+static String generateBreakpointId(const String& scriptId, int lineNumber, int columnNumber)
+{
+ return scriptId + ':' + String::number(lineNumber) + ':' + String::number(columnNumber);
+}
+
InspectorDebuggerAgent::InspectorDebuggerAgent(InstrumentingAgents* instrumentingAgents, InspectorCompositeState* inspectorState, InjectedScriptManager* injectedScriptManager)
: InspectorBaseAgent<InspectorDebuggerAgent>("Debugger", instrumentingAgents, inspectorState)
, m_injectedScriptManager(injectedScriptManager)
@@ -260,7 +265,7 @@ void InspectorDebuggerAgent::setBreakpoint(ErrorString* errorString, const RefPt
String condition = optionalCondition ? *optionalCondition : emptyString();
- String breakpointId = scriptId + ':' + String::number(lineNumber) + ':' + String::number(columnNumber);
+ String breakpointId = generateBreakpointId(scriptId, lineNumber, columnNumber);
if (m_breakpointIdToDebugServerBreakpointIds.find(breakpointId) != m_breakpointIdToDebugServerBreakpointIds.end()) {
*errorString = "Breakpoint at specified location already exists.";
return;
@@ -768,6 +773,20 @@ void ScriptDebugListener::Script::reportMemoryUsage(MemoryObjectInfo* memoryObje
info.addMember(sourceMappingURL, "sourceMappingURL");
}
+void InspectorDebuggerAgent::setBreakpoint(const String& scriptId, int lineNumber, int columnNumber)
+{
+ String breakpointId = generateBreakpointId(scriptId, lineNumber, columnNumber);
+ ScriptBreakpoint breakpoint(lineNumber, columnNumber, emptyString());
+ resolveBreakpoint(breakpointId, scriptId, breakpoint);
+}
+
+void InspectorDebuggerAgent::removeBreakpoint(const String& scriptId, int lineNumber, int columnNumber)
+{
+ String breakpointId = generateBreakpointId(scriptId, lineNumber, columnNumber);
+ ErrorString errorString;
+ removeBreakpoint(&errorString, breakpointId);
+}
+
void InspectorDebuggerAgent::reset()
{
m_scripts.clear();

Powered by Google App Engine
This is Rietveld 408576698