Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(579)

Issue 1429383002: include what you use: errno.h and string.h in media/ (Closed)

Created:
5 years, 1 month ago by Mostyn Bramley-Moore
Modified:
5 years, 1 month ago
Reviewers:
qinmin, hubbe, yukawa
CC:
chromium-reviews, imcheng+watch_chromium.org, toyoshim+midi_chromium.org, posciak+watch_chromium.org, jasonroberts+watch_google.com, avayvod+watch_chromium.org, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, xjz+watch_chromium.org, isheriff+watch_chromium.org, mlamouri+watch-media_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

include what you use: errno.h and string.h in media/ Add missing errno.h includes for errno and string.h includes for strerror. TBR=qinmin Committed: https://crrev.com/d20a1a9254b061e65754c70cbad8b323ad6d523f Cr-Commit-Position: refs/heads/master@{#360276}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M media/base/android/webaudio_media_codec_bridge.cc View 1 chunk +1 line, -0 lines 0 comments Download
M media/cast/test/utility/tap_proxy.cc View 1 chunk +1 line, -0 lines 0 comments Download
M media/midi/midi_manager_alsa.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Mostyn Bramley-Moore
Here are some include-what-you-use fixes. @qinmin: can you please take a look at media/base/android/ @hubbe: ...
5 years, 1 month ago (2015-11-07 00:06:10 UTC) #2
yukawa
media/midi/midi_manager_alsa.cc: lgtm.
5 years, 1 month ago (2015-11-07 00:11:07 UTC) #4
hubbe
On 2015/11/07 00:11:07, yukawa wrote: > media/midi/midi_manager_alsa.cc: lgtm. media/cast/test/utility/tap_proxy.cc: lgtm
5 years, 1 month ago (2015-11-07 00:15:09 UTC) #5
Mostyn Bramley-Moore
@qinmin: *ping*
5 years, 1 month ago (2015-11-12 21:00:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1429383002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1429383002/1
5 years, 1 month ago (2015-11-18 01:51:38 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-18 03:07:01 UTC) #10
commit-bot: I haz the power
5 years, 1 month ago (2015-11-18 03:07:59 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d20a1a9254b061e65754c70cbad8b323ad6d523f
Cr-Commit-Position: refs/heads/master@{#360276}

Powered by Google App Engine
This is Rietveld 408576698