Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 1429373002: include what you use: errno.h in chromecast/ (Closed)

Created:
5 years, 1 month ago by Mostyn Bramley-Moore
Modified:
5 years, 1 month ago
Reviewers:
halliwell
CC:
chromium-reviews, gunsch+watch_chromium.org, lcwu+watch_chromium.org, sadrul, halliwell+watch_chromium.org, kalyank
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

include what you use: errno.h in chromecast/ Adding some missing errno.h includes for errno in chromecast/ Committed: https://crrev.com/ae975bf9dda85dac094af37d57c34389ab4b3303 Cr-Commit-Position: refs/heads/master@{#358454}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chromecast/base/error_codes.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chromecast/crash/linux/dump_info.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Mostyn Bramley-Moore
@halliwell: here's a small include-what-you-use fix.
5 years, 1 month ago (2015-11-06 23:28:06 UTC) #2
halliwell
On 2015/11/06 23:28:06, Mostyn Bramley-Moore wrote: > @halliwell: here's a small include-what-you-use fix. lgtm
5 years, 1 month ago (2015-11-06 23:37:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1429373002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1429373002/1
5 years, 1 month ago (2015-11-06 23:40:22 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-06 23:57:18 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-06 23:58:36 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ae975bf9dda85dac094af37d57c34389ab4b3303
Cr-Commit-Position: refs/heads/master@{#358454}

Powered by Google App Engine
This is Rietveld 408576698