Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 1429353002: mac: Scope crashpad_handler’s SIGTERM handler more broadly (Closed)

Created:
5 years, 1 month ago by Mark Mentovai
Modified:
5 years, 1 month ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Target Ref:
refs/heads/master
Project:
crashpad
Visibility:
Public.

Description

mac: Scope crashpad_handler’s SIGTERM handler more broadly Previously, there was a window after starting the upload thread but before the SIGTERM handler was installed, where receipt of SIGTERM could have interrupted an in-progress upload. There was also the possibility that a second SIGTERM sent after the exception handler stopped running would interrupt an in-progress upload. By pulling the signal handler out of ExceptionHandlerServer and into the main function, these races are avoided. BUG=crashpad:25 R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/4a7d599b6494c1b76208b7136c0a8dde5d2838c1

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -92 lines) Patch
M handler/handler_main.cc View 1 5 chunks +50 lines, -0 lines 0 comments Download
M handler/mac/exception_handler_server.h View 3 chunks +17 lines, -7 lines 0 comments Download
M handler/mac/exception_handler_server.cc View 9 chunks +39 lines, -85 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Mark Mentovai
5 years, 1 month ago (2015-11-06 17:14:44 UTC) #2
Robert Sesek
LGTM
5 years, 1 month ago (2015-11-09 21:19:57 UTC) #3
Mark Mentovai
5 years, 1 month ago (2015-11-09 21:29:29 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
4a7d599b6494c1b76208b7136c0a8dde5d2838c1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698