tools/cr/cr/loader.py - Issue 142933004: [cr tool] Make context implicit

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/cr/cr/loader.py

Issue 142933004: [cr tool] Make context implicit (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/cr/cr/loader.py

diff --git a/tools/cr/cr/loader.py b/tools/cr/cr/loader.py

index 51dc940982dd8ce8adba7eb3ef0395cdb3969ae2..9a5aaca09827f73c9e60f7f1354b2ecba7f1de2a 100644

--- a/tools/cr/cr/loader.py

+++ b/tools/cr/cr/loader.py

@@ -109,6 +109,7 @@ def Scan():

# Try this one again, if progress was made on a possible dependency

remains.append(name)

if remains:

+ print "Cannot load all of", remains

Andrew Hayden (chromium.org) 2014/03/19 18:20:06 I think you want one more space here, yes?

iancottrell 2014/03/19 22:17:11 No, print adds the space for you.

# There are modules that won't import in any order.

# Print all the errors as we can't determine root cause.

for name in remains: