Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Issue 14293028: [CleanUp] Add MoveMouseToInHost to aura::test::EventGenerator (Closed)

Created:
7 years, 7 months ago by oshima
Modified:
7 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Add MoveMouseToInHost to aura::test::EventGenerator * remove local functions to move the mouse in host coordinates. * updated tests that should use host coordinates instead of root. BUG=none TEST=covered by tests. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=197651

Patch Set 1 : #

Patch Set 2 : cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -71 lines) Patch
M ash/ash_root_window_transformer_unittest.cc View 11 chunks +24 lines, -31 lines 0 comments Download
M ash/display/display_controller_unittest.cc View 11 chunks +20 lines, -27 lines 0 comments Download
M ash/display/display_manager_unittest.cc View 1 5 chunks +12 lines, -6 lines 0 comments Download
M ui/aura/test/event_generator.h View 1 chunk +12 lines, -4 lines 0 comments Download
M ui/aura/test/event_generator.cc View 2 chunks +14 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
oshima
7 years, 7 months ago (2013-04-30 21:53:27 UTC) #1
sky
LGTM
7 years, 7 months ago (2013-04-30 23:06:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/14293028/9001
7 years, 7 months ago (2013-04-30 23:16:07 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) cc_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=108851
7 years, 7 months ago (2013-05-01 01:36:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/14293028/9001
7 years, 7 months ago (2013-05-01 01:42:53 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) cc_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=108916
7 years, 7 months ago (2013-05-01 02:20:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/14293028/9001
7 years, 7 months ago (2013-05-01 16:00:12 UTC) #7
commit-bot: I haz the power
7 years, 7 months ago (2013-05-01 17:18:36 UTC) #8
Message was sent while issue was closed.
Change committed as 197651

Powered by Google App Engine
This is Rietveld 408576698