Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 14293010: Fix shared library build of preparser: properly #undef V8EXPORT (Closed)

Created:
7 years, 8 months ago by Jakob Kummerow
Modified:
7 years, 8 months ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

Fix shared library build of preparser: properly #undef V8EXPORT Committed: http://code.google.com/p/v8/source/detail?r=14290

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M include/v8-preparser.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Jakob Kummerow
PTAL.
7 years, 8 months ago (2013-04-16 14:53:49 UTC) #1
Yang
LGTM.
7 years, 8 months ago (2013-04-16 14:54:23 UTC) #2
Jakob Kummerow
7 years, 8 months ago (2013-04-16 14:55:53 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r14290 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698