Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 14293009: Nuke SamplerRegistry (Closed)

Created:
7 years, 8 months ago by yurys
Modified:
7 years, 8 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Nuke SamplerRegistry The registry is a simple list of active Samplers but uses additional Mutex. Useful parts were merged into SamplerThread, others removed completely. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=14297

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -165 lines) Patch
M src/log.h View 1 chunk +0 lines, -34 lines 0 comments Download
M src/log.cc View 1 chunk +0 lines, -61 lines 0 comments Download
M src/sampler.cc View 5 chunks +89 lines, -68 lines 0 comments Download
M src/v8.cc View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
yurys
7 years, 8 months ago (2013-04-16 14:45:40 UTC) #1
yurys
Signal handling logic was extracted into SignalHandler all-static class to reduce number of #ifdef USE_SIGNALS ...
7 years, 8 months ago (2013-04-16 14:50:21 UTC) #2
yurys
On 2013/04/16 14:50:21, Yury Semikhatsky wrote: > Signal handling logic was extracted into SignalHandler all-static ...
7 years, 8 months ago (2013-04-16 15:01:51 UTC) #3
loislo
lgtm
7 years, 8 months ago (2013-04-16 15:52:25 UTC) #4
Sven Panne
LGTM, too.
7 years, 8 months ago (2013-04-17 07:04:24 UTC) #5
yurys
7 years, 8 months ago (2013-04-17 07:20:34 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 manually as r14297.

Powered by Google App Engine
This is Rietveld 408576698