Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 14293008: Remove frame flattening calls from Chromium as it is being removed from Blink (Closed)

Created:
7 years, 8 months ago by kenneth.r.christiansen
Modified:
7 years, 8 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Remove frame flattening calls from Chromium as it is being removed from Blink Chromium does not use the frame flattening code on any platform, though it used to use it for frameset flattening on Android, but that is no longer the case. As there is no intention of ever using it, it should be removed. This change basically removed the code related to the WebCore setting. Committed on behalf of Kenneth Rohde Christiansen <kenneth.r.christiansen@intel.com>;. TBR=darin@chromium.org BUG=231898 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194745

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M AUTHORS View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/common_param_traits_macros.h View 1 chunk +0 lines, -1 line 0 comments Download
M webkit/glue/webpreferences.h View 1 chunk +0 lines, -1 line 0 comments Download
M webkit/glue/webpreferences.cc View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
kenneth.christiansen
7 years, 8 months ago (2013-04-16 18:49:21 UTC) #1
ojan
lgtm Looks like there was some duplicate work. I'll let you and Mike duke it ...
7 years, 8 months ago (2013-04-16 19:35:34 UTC) #2
kenneth.christiansen
On 2013/04/16 19:35:34, ojan wrote: > lgtm > > Looks like there was some duplicate ...
7 years, 8 months ago (2013-04-16 21:33:51 UTC) #3
Use mkwst_at_chromium.org plz.
On 2013/04/16 21:33:51, kenneth.christiansen wrote: > On 2013/04/16 19:35:34, ojan wrote: > > lgtm > ...
7 years, 8 months ago (2013-04-16 21:46:50 UTC) #4
kenneth.christiansen
> I can land this for you in the EU morning, or perhaps Ojan can ...
7 years, 8 months ago (2013-04-16 21:50:54 UTC) #5
ojan
On 2013/04/16 21:50:54, kenneth.christiansen wrote: > > I can land this for you in the ...
7 years, 8 months ago (2013-04-16 23:08:57 UTC) #6
kenneth.christiansen
> Whoops, looks like we have some paperwork to do. You're not in the chromium ...
7 years, 8 months ago (2013-04-17 07:19:06 UTC) #7
ojan
> http://dev.chromium.org/developers/contributing-code/external-contributor-checklist > > > > Please fill out the CLA form at > > ...
7 years, 8 months ago (2013-04-17 07:47:47 UTC) #8
kenneth.christiansen
> You filled out the form (the sign electronically section)? Or did you email/mail > ...
7 years, 8 months ago (2013-04-17 07:50:37 UTC) #9
Peter Beverloo
On 2013/04/17 07:50:37, kenneth.christiansen wrote: > > You filled out the form (the sign electronically ...
7 years, 8 months ago (2013-04-17 09:58:36 UTC) #10
ojan
On Wed, Apr 17, 2013 at 2:58 AM, <peter@chromium.org> wrote: > On 2013/04/17 07:50:37, kenneth.christiansen ...
7 years, 8 months ago (2013-04-17 17:18:54 UTC) #11
ojan
Committed patchset #2 manually as r194745 (presubmit successful).
7 years, 8 months ago (2013-04-18 01:46:00 UTC) #12
darin (slow to review)
7 years, 8 months ago (2013-04-18 04:50:43 UTC) #13
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698