Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 1429273002: Disable eager tracing for thread-terminated GCs. (Closed)

Created:
5 years, 1 month ago by sof
Modified:
5 years, 1 month ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, blink-reviews, kouhei+heap_chromium.org, oilpan-reviews, Mads Ager (chromium)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable eager tracing for thread-terminated GCs. The Oilpan marking phase enables and sets up a stack limit that the eager tracing calls should not exceed while visiting the live object graph. The marking phase is single threaded. The stack limit is reset and eager marking disabled once the marking phase has completed -- thread local weak processing (and its slight amount of tracing) is run with it disabled. Do not enable such an eager marking stack limit for the GCs that are run for a thread's heap when the thread is terminated, as this risks conflicting with any thread-local weak processing that is still underway. The slight performance gain that eager marking brings is not an issue for such GCs. R=haraken BUG=420515 Committed: https://crrev.com/76c2d557fcab24b4d76659301006d0d8f5e196e8 Cr-Commit-Position: refs/heads/master@{#358273}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M third_party/WebKit/Source/platform/heap/Heap.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
sof
please take a look. I believe this is what is behind this mystery assert, https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Win_Oilpan__dbg_/3209/layout-test-results/inspector/elements/styles-1/cssom-media-insert-crash-crash-log.txt ...
5 years, 1 month ago (2015-11-05 18:07:50 UTC) #2
haraken
Nice detective work, Sigbjorn! LGTM
5 years, 1 month ago (2015-11-05 23:37:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1429273002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1429273002/1
5 years, 1 month ago (2015-11-06 06:23:45 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-06 06:40:13 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/76c2d557fcab24b4d76659301006d0d8f5e196e8 Cr-Commit-Position: refs/heads/master@{#358273}
5 years, 1 month ago (2015-11-06 06:41:14 UTC) #9
sof
5 years, 1 month ago (2015-11-06 15:29:33 UTC) #10
Message was sent while issue was closed.
On 2015/11/05 23:37:44, haraken wrote:
> Nice detective work, Sigbjorn!
> 
> LGTM

Looks as if that took care of this long standing issue, last two builds are free
of it --

 
https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Win_Oilpa...

I know of no other remaining Oilpan-specific crashing issues on the bots,
currently.

Powered by Google App Engine
This is Rietveld 408576698