Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 1429263005: Revert of mandoline: Fix ICU initialization. (Closed)

Created:
5 years, 1 month ago by Elliot Glaysher
Modified:
5 years, 1 month ago
Reviewers:
jam, sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, penghuang+watch-mandoline_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, tfarina, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of mandoline: Fix ICU initialization. (patchset #31 id:570001 of https://codereview.chromium.org/1425853003/ ) Reason for revert: Failures on Chromium Mojo Linux Perf which appears to be because the perf bots don't have an up to date kernel and on Chromium Mojo Android which has some weird crash. Original issue's description: > mandoline: Fix ICU initialization. > > We need to complete the initialization of ICU before we raise the > sandbox. That means we can't pass a file descriptor to the ICU data file > across mojo pipes. Due to how Android handles resources files, we also > can't pass a file descriptor around inside the same process. So pass a > raw pointer to a memory mapped file during the sandbox warm-up phase, > and make a new option to initialize ICU from this raw pointer. > > But that just uncovers a bigger issue: we don't always call what was the > sandbox warming code. If it's general initialization that needs to be > called before we run MojoMain(), we need to include initialization code > in most all main.cc implementations. This bakes a base initialize call > into the mojo application library. > > This fixes a crash in the page cycler set, which happens when a page > tries to do date operations, which fail because of missing locale data. > This should let us raise the sandbox on the page cycler. > > BUG=546644 > > Committed: https://crrev.com/e5735ff0a8ddb61672d964a44ebc8a8ebe2b6242 > Cr-Commit-Position: refs/heads/master@{#358904} TBR=sky@chromium.org,jam@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=546644 Committed: https://crrev.com/f786c621fe5559d054a793f44ce365e86c6210a8 Cr-Commit-Position: refs/heads/master@{#358955}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -140 lines) Patch
M base/i18n/icu_util.h View 1 chunk +2 lines, -23 lines 0 comments Download
M base/i18n/icu_util.cc View 2 chunks +0 lines, -23 lines 0 comments Download
M components/html_viewer/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M components/html_viewer/global_state.cc View 2 chunks +8 lines, -4 lines 0 comments Download
M components/html_viewer/html_viewer_main.cc View 1 chunk +26 lines, -0 lines 0 comments Download
M components/resource_provider/BUILD.gn View 2 chunks +6 lines, -0 lines 0 comments Download
M components/resource_provider/public/cpp/resource_loader.h View 2 chunks +3 lines, -0 lines 0 comments Download
M components/resource_provider/public/cpp/resource_loader.cc View 2 chunks +13 lines, -0 lines 0 comments Download
M components/resource_provider/public/interfaces/resource_provider.mojom View 1 chunk +3 lines, -0 lines 0 comments Download
M components/resource_provider/resource_provider_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/resource_provider/resource_provider_impl.cc View 2 chunks +10 lines, -0 lines 0 comments Download
M mandoline/app/desktop/launcher_process.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M mandoline/services/core_services/BUILD.gn View 1 chunk +5 lines, -0 lines 0 comments Download
M mandoline/services/core_services/main.cc View 1 chunk +26 lines, -0 lines 0 comments Download
M mojo/application/public/cpp/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
D mojo/application/public/cpp/initialize_base_and_icu.cc View 1 chunk +0 lines, -43 lines 0 comments Download
M mojo/runner/BUILD.gn View 3 chunks +1 line, -7 lines 0 comments Download
M mojo/runner/child_process.cc View 3 chunks +9 lines, -6 lines 0 comments Download
M mojo/runner/context.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M mojo/runner/in_process_native_runner.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M mojo/runner/init.h View 2 chunks +0 lines, -6 lines 0 comments Download
M mojo/runner/init.cc View 2 chunks +0 lines, -19 lines 0 comments Download
M ui/views/mus/aura_init.cc View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Elliot Glaysher
Created Revert of mandoline: Fix ICU initialization.
5 years, 1 month ago (2015-11-10 23:35:02 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1429263005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1429263005/1
5 years, 1 month ago (2015-11-10 23:37:34 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-10 23:40:49 UTC) #3
commit-bot: I haz the power
5 years, 1 month ago (2015-11-10 23:42:21 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f786c621fe5559d054a793f44ce365e86c6210a8
Cr-Commit-Position: refs/heads/master@{#358955}

Powered by Google App Engine
This is Rietveld 408576698