Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(641)

Issue 1429233004: [turbofan] Fix wrong parameter indices in JSFrameSpecialization. (Closed)

Created:
5 years, 1 month ago by Benedikt Meurer
Modified:
5 years, 1 month ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix wrong parameter indices in JSFrameSpecialization. We forgot to add the number of arguments parameter in JSFrameSpecialization, which was added before the context. R=jarin@chromium.org BUG=chromium:552304 LOG=n Committed: https://crrev.com/925a2006f503691252cca74c7ef15f8b82419b7b Cr-Commit-Position: refs/heads/master@{#31856}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M src/compiler/js-frame-specialization.cc View 1 chunk +4 lines, -1 line 0 comments Download
A + test/mjsunit/regress/regress-crbug-552304.js View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Benedikt Meurer
5 years, 1 month ago (2015-11-06 12:38:51 UTC) #1
Jarin
lgtm
5 years, 1 month ago (2015-11-06 12:42:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1429233004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1429233004/1
5 years, 1 month ago (2015-11-06 12:58:03 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-06 13:12:17 UTC) #5
commit-bot: I haz the power
5 years, 1 month ago (2015-11-06 13:13:02 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/925a2006f503691252cca74c7ef15f8b82419b7b
Cr-Commit-Position: refs/heads/master@{#31856}

Powered by Google App Engine
This is Rietveld 408576698