IDL compiler: implements

IDL compiler: implements

The 'implements' statement is already supported, as it's implemented the
same as 'partial interface' (these are both dependenc*y* files).

However, turning on the existing test requires a few auxiliary changes.

This CL:
* adds a test for 'implements' to Python test files
* adds features to Python for new test cases (actually used in real files)
* removes test cases for unused features for which Perl generates incorrect test code

New features:
* EventHandler type method in dependency
* method with arguments in dependency (fix order)
* [RaisesException] on interface type method

Removed test cases:
* [Custom] attribute in dependency
* [PerContextEnabled] attribute in dependency

Also:
* Regularize naming in TestImplements.idl

BUG=239771
R=haraken
NOTRY=true

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165381

[haraken, 2014-01-20 03:50:59]

LGTM.

https://codereview.chromium.org/142923002/diff/1/Source/bindings/scripts/unst...
File Source/bindings/scripts/unstable/v8_attributes.py (right):

https://codereview.chromium.org/142923002/diff/1/Source/bindings/scripts/unst...
Source/bindings/scripts/unstable/v8_attributes.py:262: # FIXME: pass the isolate
instead of the isolated world

Let's fix the FIXME in a follow-up.

https://codereview.chromium.org/142923002/diff/1/Source/bindings/scripts/unst...
File Source/bindings/scripts/unstable/v8_methods.py (right):

https://codereview.chromium.org/142923002/diff/1/Source/bindings/scripts/unst...
Source/bindings/scripts/unstable/v8_methods.py:188: # use local variable for
value

Add FIXME. Also let's fix the FIXME. It will simplify the compiler.

[Nils Barth (inactive), 2014-01-20 04:33:17]

https://codereview.chromium.org/142923002/diff/1/Source/bindings/scripts/unst...
File Source/bindings/scripts/unstable/v8_attributes.py (right):

https://codereview.chromium.org/142923002/diff/1/Source/bindings/scripts/unst...
Source/bindings/scripts/unstable/v8_attributes.py:262: # FIXME: pass the isolate
instead of the isolated world
On 2014/01/20 03:50:59, haraken wrote:
> Let's fix the FIXME in a follow-up.

Got it, will do!

https://codereview.chromium.org/142923002/diff/1/Source/bindings/scripts/unst...
File Source/bindings/scripts/unstable/v8_methods.py (right):

https://codereview.chromium.org/142923002/diff/1/Source/bindings/scripts/unst...
Source/bindings/scripts/unstable/v8_methods.py:188: # use local variable for
value
On 2014/01/20 03:50:59, haraken wrote:
> Add FIXME. Also let's fix the FIXME. It will simplify the compiler.

This isn't a FIXME: it's a statement that we *are* using a local variable for
the value.
However, there is an existing FIXME in the template about
merging all the "assign to local variable" statements,
which I'll try doing after we switch to Python
(updating the Perl would be a huge pain).

[commit-bot: I haz the power, 2014-01-20 04:33:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nbarth@chromium.org/142923002/70001

[commit-bot: I haz the power, 2014-01-20 04:33:42]

Failed to apply patch for Source/bindings/tests/results/V8TestInterface.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/bindings/tests/results/V8TestInterface.cpp
  Hunk #4 FAILED at 504.
  Hunk #5 succeeded at 741 (offset 10 lines).
  Hunk #6 succeeded at 757 (offset 10 lines).
  Hunk #7 succeeded at 801 (offset 10 lines).
  Hunk #8 succeeded at 814 (offset 10 lines).
  Hunk #9 succeeded at 872 (offset 10 lines).
  1 out of 9 hunks FAILED -- saving rejects to file
Source/bindings/tests/results/V8TestInterface.cpp.rej

Patch:       Source/bindings/tests/results/V8TestInterface.cpp
Index: Source/bindings/tests/results/V8TestInterface.cpp
diff --git a/Source/bindings/tests/results/V8TestInterface.cpp
b/Source/bindings/tests/results/V8TestInterface.cpp
index
b1f380dee9ceb2c8eabcdf7bf103acada3931832..c7c361be2016a377fd02ab14dd3552b9cab5ae62
100644
--- a/Source/bindings/tests/results/V8TestInterface.cpp
+++ b/Source/bindings/tests/results/V8TestInterface.cpp
@@ -38,6 +38,7 @@
 #include "V8Node.h"
 #include "V8NodeList.h"
 #include "V8ReferencedType.h"
+#include "V8TestInterfaceEmpty.h"
 #include "V8TestObject.h"
 #include "bindings/tests/idls/TestImplements.h"
 #include "bindings/tests/idls/TestPartialInterface.h"
@@ -80,203 +81,162 @@ namespace TestInterfaceV8Internal {
 
 template <typename T> void V8_USE(T) { }
 
-static void implementsStaticReadOnlyAttrAttributeGetter(const
v8::PropertyCallbackInfo<v8::Value>& info)
+static void implementsStaticReadOnlyLongAttributeAttributeGetter(const
v8::PropertyCallbackInfo<v8::Value>& info)
 {
-    v8SetReturnValueInt(info, TestImplements::implementsStaticReadOnlyAttr());
+    v8SetReturnValueInt(info,
TestImplements::implementsStaticReadOnlyLongAttribute());
 }
 
-static void
implementsStaticReadOnlyAttrAttributeGetterCallback(v8::Local<v8::String>, const
v8::PropertyCallbackInfo<v8::Value>& info)
+static void
implementsStaticReadOnlyLongAttributeAttributeGetterCallback(v8::Local<v8::String>,
const v8::PropertyCallbackInfo<v8::Value>& info)
 {
     TRACE_EVENT_SET_SAMPLING_STATE("Blink", "DOMGetter");
-    TestInterfaceV8Internal::implementsStaticReadOnlyAttrAttributeGetter(info);
+   
TestInterfaceV8Internal::implementsStaticReadOnlyLongAttributeAttributeGetter(info);
     TRACE_EVENT_SET_SAMPLING_STATE("V8", "V8Execution");
 }
 
-static void implementsStaticAttrAttributeGetter(const
v8::PropertyCallbackInfo<v8::Value>& info)
+static void implementsStaticStringAttributeAttributeGetter(const
v8::PropertyCallbackInfo<v8::Value>& info)
 {
-    v8SetReturnValueString(info, TestImplements::implementsStaticAttr(),
info.GetIsolate());
+    v8SetReturnValueString(info,
TestImplements::implementsStaticStringAttribute(), info.GetIsolate());
 }
 
-static void implementsStaticAttrAttributeGetterCallback(v8::Local<v8::String>,
const v8::PropertyCallbackInfo<v8::Value>& info)
+static void
implementsStaticStringAttributeAttributeGetterCallback(v8::Local<v8::String>,
const v8::PropertyCallbackInfo<v8::Value>& info)
 {
     TRACE_EVENT_SET_SAMPLING_STATE("Blink", "DOMGetter");
-    TestInterfaceV8Internal::implementsStaticAttrAttributeGetter(info);
+   
TestInterfaceV8Internal::implementsStaticStringAttributeAttributeGetter(info);
     TRACE_EVENT_SET_SAMPLING_STATE("V8", "V8Execution");
 }
 
-static void implementsStaticAttrAttributeSetter(v8::Local<v8::Value> jsValue,
const v8::PropertyCallbackInfo<void>& info)
+static void implementsStaticStringAttributeAttributeSetter(v8::Local<v8::Value>
jsValue, const v8::PropertyCallbackInfo<void>& info)
 {
     V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<>, cppValue,
jsValue);
-    TestImplements::setImplementsStaticAttr(cppValue);
+    TestImplements::setImplementsStaticStringAttribute(cppValue);
 }
 
-static void implementsStaticAttrAttributeSetterCallback(v8::Local<v8::String>,
v8::Local<v8::Value> jsValue, const v8::PropertyCallbackInfo<void>& info)
+static void
implementsStaticStringAttributeAttributeSetterCallback(v8::Local<v8::String>,
v8::Local<v8::Value> jsValue, const v8::PropertyCallbackInfo<void>& info)
 {
     TRACE_EVENT_SET_SAMPLING_STATE("Blink", "DOMSetter");
-    TestInterfaceV8Internal::implementsStaticAttrAttributeSetter(jsValue,
info);
+   
TestInterfaceV8Internal::implementsStaticStringAttributeAttributeSetter(jsValue,
info);
     TRACE_EVENT_SET_SAMPLING_STATE("V8", "V8Execution");
 }
 
-static void implementsStr1AttributeGetter(const
v8::PropertyCallbackInfo<v8::Value>& info)
+static void implementsReadonlyStringAttributeAttributeGetter(const
v8::PropertyCallbackInfo<v8::Value>& info)
 {
     TestInterface* imp = V8TestInterface::toNative(info.Holder());
-    v8SetReturnValueString(info, TestImplements::implementsStr1(imp),
info.GetIsolate());
+    v8SetReturnValueString(info,
TestImplements::implementsReadonlyStringAttribute(imp), info.GetIsolate());
 }
 
-static void implementsStr1AttributeGetterCallback(v8::Local<v8::String>, const
v8::PropertyCallbackInfo<v8::Value>& info)
+static void
implementsReadonlyStringAttributeAttributeGetterCallback(v8::Local<v8::String>,
const v8::PropertyCallbackInfo<v8::Value>& info)
 {
     TRACE_EVENT_SET_SAMPLING_STATE("Blink", "DOMGetter");
-    TestInterfaceV8Internal::implementsStr1AttributeGetter(info);
+   
TestInterfaceV8Internal::implementsReadonlyStringAttributeAttributeGetter(info);
     TRACE_EVENT_SET_SAMPLING_STATE("V8", "V8Execution");
 }
 
-static void implementsStr2AttributeGetter(const
v8::PropertyCallbackInfo<v8::Value>& info)
+static void implementsStringAttributeAttributeGetter(const
v8::PropertyCallbackInfo<v8::Value>& info)
 {
     TestInterface* imp = V8TestInterface::toNative(info.Holder());
-    v8SetReturnValueString(info, TestImplements::implementsStr2(imp),
info.GetIsolate());
+    v8SetReturnValueString(info,
TestImplements::implementsStringAttribute(imp), info.GetIsolate());
 }
 
-static void implementsStr2AttributeGetterCallback(v8::Local<v8::String>, const
v8::PropertyCallbackInfo<v8::Value>& info)
+static void
implementsStringAttributeAttributeGetterCallback(v8::Local<v8::String>, const
v8::PropertyCallbackInfo<v8::Value>& info)
 {
     TRACE_EVENT_SET_SAMPLING_STATE("Blink", "DOMGetter");
-    TestInterfaceV8Internal::implementsStr2AttributeGetter(info);
+    TestInterfaceV8Internal::implementsStringAttributeAttributeGetter(info);
     TRACE_EVENT_SET_SAMPLING_STATE("V8", "V8Execution");
 }
 
-static void implementsStr2AttributeSetter(v8::Local<v8::Value> jsValue, const
v8::PropertyCallbackInfo<void>& info)
+static void implementsStringAttributeAttributeSetter(v8::Local<v8::Value>
jsValue, const v8::PropertyCallbackInfo<void>& info)
 {
     TestInterface* imp = V8TestInterface::toNative(info.Holder());
     V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<>, cppValue,
jsValue);
-    TestImplements::setImplementsStr2(imp, cppValue);
+    TestImplements::setImplementsStringAttribute(imp, cppValue);
 }
 
-static void implementsStr2AttributeSetterCallback(v8::Local<v8::String>,
v8::Local<v8::Value> jsValue, const v8::PropertyCallbackInfo<void>& info)
+static void
implementsStringAttributeAttributeSetterCallback(v8::Local<v8::String>,
v8::Local<v8::Value> jsValue, const v8::PropertyCallbackInfo<void>& info)
 {
     TRACE_EVENT_SET_SAMPLING_STATE("Blink", "DOMSetter");
-    TestInterfaceV8Internal::implementsStr2AttributeSetter(jsValue, info);
+    TestInterfaceV8Internal::implementsStringAttributeAttributeSetter(jsValue,
info);
     TRACE_EVENT_SET_SAMPLING_STATE("V8", "V8Execution");
 }
 
-static void implementsStr3AttributeGetterCallback(v8::Local<v8::String>, const
v8::PropertyCallbackInfo<v8::Value>& info)
-{
-    TRACE_EVENT_SET_SAMPLING_STATE("Blink", "DOMGetter");
-    V8TestInterface::implementsStr3AttributeGetterCustom(info);
-    TRACE_EVENT_SET_SAMPLING_STATE("V8", "V8Execution");
-}
-
-static void implementsStr3AttributeSetterCallback(v8::Local<v8::String>,
v8::Local<v8::Value> jsValue, const v8::PropertyCallbackInfo<void>& info)
-{
-    TRACE_EVENT_SET_SAMPLING_STATE("Blink", "DOMSetter");
-    V8TestInterface::implementsStr3AttributeSetterCustom(jsValue, info);
-    TRACE_EVENT_SET_SAMPLING_STATE("V8", "V8Execution");
-}
-
-static void implementsNodeAttributeGetter(const
v8::PropertyCallbackInfo<v8::Value>& info)
+static void implementsNodeAttributeAttributeGetter(const
v8::PropertyCallbackInfo<v8::Value>& info)
 {
     TestInterface* imp = V8TestInterface::toNative(info.Holder());
-    v8SetReturnValueFast(info, TestImplements::implementsNode(imp), imp);
+    v8SetReturnValueFast(info, TestImplements::implementsNodeAttribute(imp),
imp);
 }
 
-static void implementsNodeAttributeGetterCallback(v8::Local<v8::String>, const
v8::PropertyCallbackInfo<v8::Value>& info)
+static void
implementsNodeAttributeAttributeGetterCallback(v8::Local<v8::String>, const
v8::PropertyCallbackInfo<v8::Value>& info)
 {
     TRACE_EVENT_SET_SAMPLING_STATE("Blink", "DOMGetter");
-    TestInterfaceV8Internal::implementsNodeAttributeGetter(info);
+    TestInterfaceV8Internal::implementsNodeAttributeAttributeGetter(info);
     TRACE_EVENT_SET_SAMPLING_STATE("V8", "V8Execution");
 }
 
-static void implementsNodeAttributeSetter(v8::Local<v8::Value> jsValue, const
v8::PropertyCallbackInfo<void>& info)
+static void implementsNodeAttributeAttributeSetter(v8::Local<v8::Value>
jsValue, const v8::PropertyCallbackInfo<void>& info)
 {
     TestInterface* imp = V8TestInterface::toNative(info.Holder());
     V8TRYCATCH_VOID(Node*, cppValue, V8Node::hasInstance(jsValue,
info.GetIsolate(), worldType(info.GetIsolate())) ?
V8Node::toNative(v8::Handle<v8::Object>::Cast(jsValue)) : 0);
-    TestImplements::setImplementsNode(imp, WTF::getPtr(cppValue));
+    TestImplements::setImplementsNodeAttribute(imp, WTF::getPtr(cppValue));
 }
 
-static void implementsNodeAttributeSetterCallback(v8::Local<v8::String>,
v8::Local<v8::Value> jsValue, const v8::PropertyCallbackInfo<void>& info)
+static void implementsNodeAtt…
(message too large)

[commit-bot: I haz the power, 2014-01-20 04:41:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nbarth@chromium.org/142923002/120001

[commit-bot: I haz the power, 2014-01-20 04:41:44]

Failed to apply patch for Source/bindings/tests/results/V8TestInterface.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/bindings/tests/results/V8TestInterface.cpp
  Hunk #4 FAILED at 504.
  Hunk #5 succeeded at 741 (offset 10 lines).
  Hunk #6 succeeded at 757 (offset 10 lines).
  Hunk #7 succeeded at 801 (offset 10 lines).
  Hunk #8 succeeded at 814 (offset 10 lines).
  Hunk #9 succeeded at 872 (offset 10 lines).
  1 out of 9 hunks FAILED -- saving rejects to file
Source/bindings/tests/results/V8TestInterface.cpp.rej

Patch:       Source/bindings/tests/results/V8TestInterface.cpp
Index: Source/bindings/tests/results/V8TestInterface.cpp
diff --git a/Source/bindings/tests/results/V8TestInterface.cpp
b/Source/bindings/tests/results/V8TestInterface.cpp
index
b1f380dee9ceb2c8eabcdf7bf103acada3931832..c7c361be2016a377fd02ab14dd3552b9cab5ae62
100644
--- a/Source/bindings/tests/results/V8TestInterface.cpp
+++ b/Source/bindings/tests/results/V8TestInterface.cpp
@@ -38,6 +38,7 @@
 #include "V8Node.h"
 #include "V8NodeList.h"
 #include "V8ReferencedType.h"
+#include "V8TestInterfaceEmpty.h"
 #include "V8TestObject.h"
 #include "bindings/tests/idls/TestImplements.h"
 #include "bindings/tests/idls/TestPartialInterface.h"
@@ -80,203 +81,162 @@ namespace TestInterfaceV8Internal {
 
 template <typename T> void V8_USE(T) { }
 
-static void implementsStaticReadOnlyAttrAttributeGetter(const
v8::PropertyCallbackInfo<v8::Value>& info)
+static void implementsStaticReadOnlyLongAttributeAttributeGetter(const
v8::PropertyCallbackInfo<v8::Value>& info)
 {
-    v8SetReturnValueInt(info, TestImplements::implementsStaticReadOnlyAttr());
+    v8SetReturnValueInt(info,
TestImplements::implementsStaticReadOnlyLongAttribute());
 }
 
-static void
implementsStaticReadOnlyAttrAttributeGetterCallback(v8::Local<v8::String>, const
v8::PropertyCallbackInfo<v8::Value>& info)
+static void
implementsStaticReadOnlyLongAttributeAttributeGetterCallback(v8::Local<v8::String>,
const v8::PropertyCallbackInfo<v8::Value>& info)
 {
     TRACE_EVENT_SET_SAMPLING_STATE("Blink", "DOMGetter");
-    TestInterfaceV8Internal::implementsStaticReadOnlyAttrAttributeGetter(info);
+   
TestInterfaceV8Internal::implementsStaticReadOnlyLongAttributeAttributeGetter(info);
     TRACE_EVENT_SET_SAMPLING_STATE("V8", "V8Execution");
 }
 
-static void implementsStaticAttrAttributeGetter(const
v8::PropertyCallbackInfo<v8::Value>& info)
+static void implementsStaticStringAttributeAttributeGetter(const
v8::PropertyCallbackInfo<v8::Value>& info)
 {
-    v8SetReturnValueString(info, TestImplements::implementsStaticAttr(),
info.GetIsolate());
+    v8SetReturnValueString(info,
TestImplements::implementsStaticStringAttribute(), info.GetIsolate());
 }
 
-static void implementsStaticAttrAttributeGetterCallback(v8::Local<v8::String>,
const v8::PropertyCallbackInfo<v8::Value>& info)
+static void
implementsStaticStringAttributeAttributeGetterCallback(v8::Local<v8::String>,
const v8::PropertyCallbackInfo<v8::Value>& info)
 {
     TRACE_EVENT_SET_SAMPLING_STATE("Blink", "DOMGetter");
-    TestInterfaceV8Internal::implementsStaticAttrAttributeGetter(info);
+   
TestInterfaceV8Internal::implementsStaticStringAttributeAttributeGetter(info);
     TRACE_EVENT_SET_SAMPLING_STATE("V8", "V8Execution");
 }
 
-static void implementsStaticAttrAttributeSetter(v8::Local<v8::Value> jsValue,
const v8::PropertyCallbackInfo<void>& info)
+static void implementsStaticStringAttributeAttributeSetter(v8::Local<v8::Value>
jsValue, const v8::PropertyCallbackInfo<void>& info)
 {
     V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<>, cppValue,
jsValue);
-    TestImplements::setImplementsStaticAttr(cppValue);
+    TestImplements::setImplementsStaticStringAttribute(cppValue);
 }
 
-static void implementsStaticAttrAttributeSetterCallback(v8::Local<v8::String>,
v8::Local<v8::Value> jsValue, const v8::PropertyCallbackInfo<void>& info)
+static void
implementsStaticStringAttributeAttributeSetterCallback(v8::Local<v8::String>,
v8::Local<v8::Value> jsValue, const v8::PropertyCallbackInfo<void>& info)
 {
     TRACE_EVENT_SET_SAMPLING_STATE("Blink", "DOMSetter");
-    TestInterfaceV8Internal::implementsStaticAttrAttributeSetter(jsValue,
info);
+   
TestInterfaceV8Internal::implementsStaticStringAttributeAttributeSetter(jsValue,
info);
     TRACE_EVENT_SET_SAMPLING_STATE("V8", "V8Execution");
 }
 
-static void implementsStr1AttributeGetter(const
v8::PropertyCallbackInfo<v8::Value>& info)
+static void implementsReadonlyStringAttributeAttributeGetter(const
v8::PropertyCallbackInfo<v8::Value>& info)
 {
     TestInterface* imp = V8TestInterface::toNative(info.Holder());
-    v8SetReturnValueString(info, TestImplements::implementsStr1(imp),
info.GetIsolate());
+    v8SetReturnValueString(info,
TestImplements::implementsReadonlyStringAttribute(imp), info.GetIsolate());
 }
 
-static void implementsStr1AttributeGetterCallback(v8::Local<v8::String>, const
v8::PropertyCallbackInfo<v8::Value>& info)
+static void
implementsReadonlyStringAttributeAttributeGetterCallback(v8::Local<v8::String>,
const v8::PropertyCallbackInfo<v8::Value>& info)
 {
     TRACE_EVENT_SET_SAMPLING_STATE("Blink", "DOMGetter");
-    TestInterfaceV8Internal::implementsStr1AttributeGetter(info);
+   
TestInterfaceV8Internal::implementsReadonlyStringAttributeAttributeGetter(info);
     TRACE_EVENT_SET_SAMPLING_STATE("V8", "V8Execution");
 }
 
-static void implementsStr2AttributeGetter(const
v8::PropertyCallbackInfo<v8::Value>& info)
+static void implementsStringAttributeAttributeGetter(const
v8::PropertyCallbackInfo<v8::Value>& info)
 {
     TestInterface* imp = V8TestInterface::toNative(info.Holder());
-    v8SetReturnValueString(info, TestImplements::implementsStr2(imp),
info.GetIsolate());
+    v8SetReturnValueString(info,
TestImplements::implementsStringAttribute(imp), info.GetIsolate());
 }
 
-static void implementsStr2AttributeGetterCallback(v8::Local<v8::String>, const
v8::PropertyCallbackInfo<v8::Value>& info)
+static void
implementsStringAttributeAttributeGetterCallback(v8::Local<v8::String>, const
v8::PropertyCallbackInfo<v8::Value>& info)
 {
     TRACE_EVENT_SET_SAMPLING_STATE("Blink", "DOMGetter");
-    TestInterfaceV8Internal::implementsStr2AttributeGetter(info);
+    TestInterfaceV8Internal::implementsStringAttributeAttributeGetter(info);
     TRACE_EVENT_SET_SAMPLING_STATE("V8", "V8Execution");
 }
 
-static void implementsStr2AttributeSetter(v8::Local<v8::Value> jsValue, const
v8::PropertyCallbackInfo<void>& info)
+static void implementsStringAttributeAttributeSetter(v8::Local<v8::Value>
jsValue, const v8::PropertyCallbackInfo<void>& info)
 {
     TestInterface* imp = V8TestInterface::toNative(info.Holder());
     V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<>, cppValue,
jsValue);
-    TestImplements::setImplementsStr2(imp, cppValue);
+    TestImplements::setImplementsStringAttribute(imp, cppValue);
 }
 
-static void implementsStr2AttributeSetterCallback(v8::Local<v8::String>,
v8::Local<v8::Value> jsValue, const v8::PropertyCallbackInfo<void>& info)
+static void
implementsStringAttributeAttributeSetterCallback(v8::Local<v8::String>,
v8::Local<v8::Value> jsValue, const v8::PropertyCallbackInfo<void>& info)
 {
     TRACE_EVENT_SET_SAMPLING_STATE("Blink", "DOMSetter");
-    TestInterfaceV8Internal::implementsStr2AttributeSetter(jsValue, info);
+    TestInterfaceV8Internal::implementsStringAttributeAttributeSetter(jsValue,
info);
     TRACE_EVENT_SET_SAMPLING_STATE("V8", "V8Execution");
 }
 
-static void implementsStr3AttributeGetterCallback(v8::Local<v8::String>, const
v8::PropertyCallbackInfo<v8::Value>& info)
-{
-    TRACE_EVENT_SET_SAMPLING_STATE("Blink", "DOMGetter");
-    V8TestInterface::implementsStr3AttributeGetterCustom(info);
-    TRACE_EVENT_SET_SAMPLING_STATE("V8", "V8Execution");
-}
-
-static void implementsStr3AttributeSetterCallback(v8::Local<v8::String>,
v8::Local<v8::Value> jsValue, const v8::PropertyCallbackInfo<void>& info)
-{
-    TRACE_EVENT_SET_SAMPLING_STATE("Blink", "DOMSetter");
-    V8TestInterface::implementsStr3AttributeSetterCustom(jsValue, info);
-    TRACE_EVENT_SET_SAMPLING_STATE("V8", "V8Execution");
-}
-
-static void implementsNodeAttributeGetter(const
v8::PropertyCallbackInfo<v8::Value>& info)
+static void implementsNodeAttributeAttributeGetter(const
v8::PropertyCallbackInfo<v8::Value>& info)
 {
     TestInterface* imp = V8TestInterface::toNative(info.Holder());
-    v8SetReturnValueFast(info, TestImplements::implementsNode(imp), imp);
+    v8SetReturnValueFast(info, TestImplements::implementsNodeAttribute(imp),
imp);
 }
 
-static void implementsNodeAttributeGetterCallback(v8::Local<v8::String>, const
v8::PropertyCallbackInfo<v8::Value>& info)
+static void
implementsNodeAttributeAttributeGetterCallback(v8::Local<v8::String>, const
v8::PropertyCallbackInfo<v8::Value>& info)
 {
     TRACE_EVENT_SET_SAMPLING_STATE("Blink", "DOMGetter");
-    TestInterfaceV8Internal::implementsNodeAttributeGetter(info);
+    TestInterfaceV8Internal::implementsNodeAttributeAttributeGetter(info);
     TRACE_EVENT_SET_SAMPLING_STATE("V8", "V8Execution");
 }
 
-static void implementsNodeAttributeSetter(v8::Local<v8::Value> jsValue, const
v8::PropertyCallbackInfo<void>& info)
+static void implementsNodeAttributeAttributeSetter(v8::Local<v8::Value>
jsValue, const v8::PropertyCallbackInfo<void>& info)
 {
     TestInterface* imp = V8TestInterface::toNative(info.Holder());
     V8TRYCATCH_VOID(Node*, cppValue, V8Node::hasInstance(jsValue,
info.GetIsolate(), worldType(info.GetIsolate())) ?
V8Node::toNative(v8::Handle<v8::Object>::Cast(jsValue)) : 0);
-    TestImplements::setImplementsNode(imp, WTF::getPtr(cppValue));
+    TestImplements::setImplementsNodeAttribute(imp, WTF::getPtr(cppValue));
 }
 
-static void implementsNodeAttributeSetterCallback(v8::Local<v8::String>,
v8::Local<v8::Value> jsValue, const v8::PropertyCallbackInfo<void>& info)
+static void implementsNodeAtt…
(message too large)

[Nils Barth (inactive), 2014-01-20 04:49:24]

Patch failures due to test result changes from re changes, which haven't landed
yet.
Removed and landing this first.

[commit-bot: I haz the power, 2014-01-20 04:49:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nbarth@chromium.org/142923002/150001

[commit-bot: I haz the power, 2014-01-20 04:50:00]

Change committed as 165381