Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3988)

Unified Diff: blimp/net/stream_socket_connection.h

Issue 1429193002: Add interfaces for most major Blimp net components. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address wez's feedback. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/net/stream_socket_connection.h
diff --git a/blimp/net/stream_socket_connection.h b/blimp/net/stream_socket_connection.h
index 9739a09b482e936dc29d9a89faaa0436d1f85e57..1006f26c024d654bafd117011b2aaa1162102dd0 100644
--- a/blimp/net/stream_socket_connection.h
+++ b/blimp/net/stream_socket_connection.h
@@ -19,8 +19,7 @@ namespace blimp {
class StreamSocketConnection : public BlimpConnection {
public:
explicit StreamSocketConnection(scoped_ptr<net::StreamSocket> socket);
-
- ~StreamSocketConnection() override;
+ ~StreamSocketConnection();
Wez 2015/11/12 03:45:57 This seems dubious; if BlimpConnection can be deri
Kevin M 2015/11/12 19:03:47 Done.
Wez 2015/11/12 20:12:55 I actually meant BlimpConnection's dtor - it's sti
private:
scoped_ptr<net::StreamSocket> socket_;

Powered by Google App Engine
This is Rietveld 408576698