Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Side by Side Diff: blimp/engine/net/engine_connection_manager.h

Issue 1429193002: Add interfaces for most major Blimp net components. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Import multiplexer changes from 1434533005 Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef BLIMP_ENGINE_NET_ENGINE_CONNECTION_MANAGER_H_
6 #define BLIMP_ENGINE_NET_ENGINE_CONNECTION_MANAGER_H_
7
8 #include "blimp/net/blimp_connection.h"
9 #include "blimp/net/connection_handler.h"
10
11 namespace blimp {
12
13 // Coordinates the channel creation and authentication workflows for
14 // incoming (Engine) network connections.
Wez 2015/11/12 00:12:53 Does/will this class implement e.g. rate limiting
Kevin M 2015/11/12 01:53:15 Yes. Added TODO
15 class EngineConnectionManager : public ConnectionHandler,
16 public BlimpConnection::DisconnectObserver {
17 public:
18 explicit EngineConnectionManager(ConnectionHandler* browser_session);
Wez 2015/11/12 00:12:53 nit: See comment on client connection manager re n
19
20 // Accepts new BlimpConnections from |transport_| as fast as they arrive.
21 void StartListening();
22
23 // ConnectionHandler implementation.
24 // Handles a new connection from a Transport and passes it to a new
25 // EngineAuthHandler.
Wez 2015/11/12 00:12:53 nit: See client equivalent re comment style/conten
26 void HandleConnection(scoped_ptr<BlimpConnection> connection) override;
27
28 // BlimpConnection::DisconnectObserver implementation.
29 void OnDisconnected() override;
Wez 2015/11/12 00:12:53 nit: Add a comment to clarify why this is needed?
Kevin M 2015/11/12 01:53:15 Actually, it's not needed here - there'll be hangi
30 };
Wez 2015/11/12 00:12:53 DISALLOW_COPY_AND_ASSIGN
Kevin M 2015/11/12 01:53:15 Done.
31
32 } // namespace blimp
33
34 #endif // BLIMP_ENGINE_NET_ENGINE_CONNECTION_MANAGER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698