blimp/engine/net/BUILD.gn - Issue 1429193002: Add interfaces for most major Blimp net components.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: blimp/engine/net/BUILD.gn

Issue 1429193002: Add interfaces for most major Blimp net components. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Import multiplexer changes from 1434533005 Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« blimp/engine/browser/blimp_engine_session.h ('K') | « blimp/engine/browser/blimp_engine_session.cc ('k') | blimp/engine/net/engine_connection_manager.h » ('j') | blimp/engine/net/engine_connection_manager.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 # Copyright 2015 The Chromium Authors. All rights reserved.	1 # Copyright 2015 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 source_set("core") {	5 source_set("net") {
	Wez 2015/11/12 00:12:53 Re the directory structure; it seems overkill to h Re the directory structure; it seems overkill to have client/net and engine/net - could we just have blimp/net and prefix the classes in there with client_ or engine_ as appropriate
6 sources = [	6 sources = [

7 "data_use_user_data.cc",	7 "engine_connection_manager.cc",

8 "data_use_user_data.h",	8 "engine_connection_manager.h",

9 ]	9 ]

	10

10 deps = [	11 deps = [

11 "//base",	12 "//base",

	13 "//blimp/net:blimp_net",

12 "//net",	14 "//net",

13 ]	15 ]

14 }	16 }

OLD	NEW