Add interfaces for most major Blimp net components.

blimp/client/net/client_connection_manager.h

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef BLIMP_CLIENT_NET_CLIENT_CONNECTION_MANAGER_H_
+#define BLIMP_CLIENT_NET_CLIENT_CONNECTION_MANAGER_H_
+
+#include "base/macros.h"
+#include "blimp/net/blimp_connection.h"
+#include "blimp/net/connection_handler.h"
+
+namespace blimp {
+
+// Coordinates the channel creation and authentication workflows for
+// outgoing (Client) network connections.
+class ClientConnectionManager : public ConnectionHandler,
+                                BlimpConnection::DisconnectObserver {
+  explicit ClientConnectionManager(ConnectionHandler* client_browser_session);

[Wez, 2015/11/12 00:12:53]

Add a comment to clarify ownership/lifetime expectations for ConenctionHandler.

Also, this class doesn't "know" anything about ClientBrowserSession, so give the
parameter a more appropriate name, e.g. connection_handler!

[Kevin M, 2015/11/12 01:53:15]

Done.

+
+  ~ClientConnectionManager();

[Wez, 2015/11/12 00:12:53]

This should be an override (see comment on ConnectionHandler).

[Kevin M, 2015/11/12 01:53:15]

Done.

+
+  void Connect();
+
+  // ConnectionHandler implementation.
+  // Handles a new connection from a Transport and passes it to a new
+  // ClientAuthHandler.

[Wez, 2015/11/12 00:12:53]

ClientAuthHandler is an internal implementation detail; I'd recommend "Handles a
new connection, authenticating it before passing it on to the underlying
connection handler, if successful."

+  void HandleConnection(scoped_ptr<BlimpConnection> connection) override;
+
+  // BlimpConnection::DisconnectObserver implementation.
+  // Called when an authenticated BlimpConnection is disconnected, which may
+  // trigger reconnection.

[Wez, 2015/11/12 00:12:53]

It's not clear from the class level description that this class does
re-connections - I'd suggest making that clear there and then this comment can
simply be "Used to implement re-connect logic on unexpected disconnections." or
similar.

[Kevin M, 2015/11/12 01:53:15]

Done.

+  void OnDisconnected() override;
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(ClientConnectionManager);
+};
+
+}  // namespace blimp
+
+#endif  // BLIMP_CLIENT_NET_CLIENT_CONNECTION_MANAGER_H_