Chromium Code Reviews Chromium Code Reviews
Issue 1429193002:
Add interfaces for most major Blimp net components. (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| OLD | NEW |
|---|---|
| 1 # Copyright 2015 The Chromium Authors. All rights reserved. | 1 # Copyright 2015 The Chromium Authors. All rights reserved. |
| 2 # Use of this source code is governed by a BSD-style license that can be | 2 # Use of this source code is governed by a BSD-style license that can be |
| 3 # found in the LICENSE file. | 3 # found in the LICENSE file. |
| 4 | 4 |
| 5 component("blimp_net") { | 5 component("blimp_net") { |
| 6 sources = [ | 6 sources = [ |
| 7 "blimp_connection.cc", | 7 "blimp_connection.cc", |
| 8 "blimp_connection.h", | 8 "blimp_connection.h", |
| 9 "blimp_message_dispatcher.cc", | 9 "blimp_message_checkpoint_observer.h", |
| 10 "blimp_message_dispatcher.h", | 10 "blimp_message_demultiplexer.cc", |
| 11 "blimp_message_demultiplexer.h", | |
| 12 "blimp_message_multiplexer.cc", | |
| 13 "blimp_message_multiplexer.h", | |
| 14 "blimp_message_output_buffer.cc", | |
| 15 "blimp_message_output_buffer.h", | |
| 16 "blimp_message_processor.h", | |
| 11 "blimp_message_receiver.h", | 17 "blimp_message_receiver.h", |
| 12 "blimp_net_export.h", | 18 "blimp_net_export.h", |
| 13 "blimp_transport.h", | 19 "blimp_transport.h", |
| 20 "client_connection_manager.cc", | |
| 21 "client_connection_manager.h", | |
| 14 "common.cc", | 22 "common.cc", |
| 15 "common.h", | 23 "common.h", |
| 16 "packet_reader.h", | 24 "connection_handler.h", |
| 17 "packet_writer.h", | 25 "engine_connection_manager.cc", |
| 26 "engine_connection_manager.h", | |
| 18 "stream_packet_reader.cc", | 27 "stream_packet_reader.cc", |
| 19 "stream_packet_reader.h", | 28 "stream_packet_reader.h", |
| 20 "stream_packet_writer.cc", | 29 "stream_packet_writer.cc", |
| 21 "stream_packet_writer.h", | 30 "stream_packet_writer.h", |
| 22 "stream_socket_connection.cc", | 31 "stream_socket_connection.cc", |
| 23 "stream_socket_connection.h", | 32 "stream_socket_connection.h", |
| 24 "tcp_client_transport.cc", | 33 "tcp_client_transport.cc", |
| 25 "tcp_client_transport.h", | 34 "tcp_client_transport.h", |
| 26 ] | 35 ] |
| 27 | 36 |
| 28 defines = [ "BLIMP_NET_IMPLEMENTATION=1" ] | 37 defines = [ "BLIMP_NET_IMPLEMENTATION=1" ] |
| 29 | 38 |
| 30 deps = [ | 39 deps = [ |
| 31 "//base", | 40 "//base", |
| 32 "//blimp/common/proto", | 41 "//blimp/common/proto", |
| 33 "//net", | 42 "//net", |
| 34 ] | 43 ] |
| 35 } | 44 } |
| 36 | 45 |
| 37 source_set("unit_tests") { | 46 source_set("unit_tests") { |
| 38 testonly = true | 47 testonly = true |
| 39 | 48 |
| 40 sources = [ | 49 sources = [ |
| 41 "blimp_message_dispatcher_unittest.cc", | 50 "blimp_message_demultiplexer_unittest.cc", |
|
Wez
2015/11/12 03:45:56
Are there no other unit-tests added by this CL?
Kevin M
2015/11/12 19:03:47
This is just interfaces and stubs. I kept unit tes
| |
| 42 "stream_packet_reader_unittest.cc", | 51 "stream_packet_reader_unittest.cc", |
| 43 "stream_packet_writer_unittest.cc", | 52 "stream_packet_writer_unittest.cc", |
| 44 "test_common.cc", | 53 "test_common.cc", |
| 45 "test_common.h", | 54 "test_common.h", |
| 46 ] | 55 ] |
| 47 | 56 |
| 48 deps = [ | 57 deps = [ |
| 49 ":blimp_net", | 58 ":blimp_net", |
| 50 "//base", | 59 "//base", |
| 51 "//base/test:run_all_unittests", | 60 "//base/test:run_all_unittests", |
| 52 "//base/test:test_support", | 61 "//base/test:test_support", |
| 53 "//blimp/common/proto", | 62 "//blimp/common/proto", |
| 54 "//net:test_support", | 63 "//net:test_support", |
| 55 "//testing/gmock", | 64 "//testing/gmock", |
| 56 "//testing/gtest", | 65 "//testing/gtest", |
| 57 ] | 66 ] |
| 58 } | 67 } |
| OLD | NEW |
