Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 1429073002: Fix //tools/gn/example on Linux: missing current_os and related vars (Closed)

Created:
5 years, 1 month ago by tsniatowski
Modified:
5 years, 1 month ago
Reviewers:
brettw
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix //tools/gn/example on Linux: missing current_os and related vars The example GN project's BUILDCONIG.gn needs to set {target,current}_{os,cpu) variables like the Chromium BUILDCONFIG file does. Otherwise some conditionals don't work like they do in Chromium and the project doesn't link on Linux, which is needlessly confusing. To test, `gn gen out' in //tools/gn/example, and then `ninja -C out'. R=brettw@chromium.org BUG= Committed: https://crrev.com/763cdd3e2a8143c6c4a7b0991579dd21aaf1aeac Cr-Commit-Position: refs/heads/master@{#357329}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M tools/gn/example/build/BUILDCONFIG.gn View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
tsniatowski
5 years, 1 month ago (2015-11-02 07:33:23 UTC) #1
brettw
lgtm
5 years, 1 month ago (2015-11-02 08:37:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1429073002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1429073002/1
5 years, 1 month ago (2015-11-02 09:56:12 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-02 10:50:12 UTC) #5
commit-bot: I haz the power
5 years, 1 month ago (2015-11-02 10:51:01 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/763cdd3e2a8143c6c4a7b0991579dd21aaf1aeac
Cr-Commit-Position: refs/heads/master@{#357329}

Powered by Google App Engine
This is Rietveld 408576698